915265 - Loading topcrashers with unknown product should produce a 404 error

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

If you try to load Top Crashers with https://crash-stats.mozilla.com/topcrasher/products/Camino/versions/2.0.1 you get way too far into the view function. 

See 
 https://errormill.mozilla.org/webtools/socorro-prod/group/104894/

Comment 1

[Peter Bengtsson [:peterbe]]

Pull request: https://github.com/mozilla/socorro/pull/1492

Comment 2

[Peter Bengtsson [:peterbe]]

:rhelmer mind taking a quick r?

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Peter Bengtsson [:peterbe] from comment #2)
> :rhelmer mind taking a quick r?

sure

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/b762e32ca20b77e03eac5e82c52e2ab18af4da67
fixes bug 915265 - Loading topcrashers with unknown product doesn't 404, r=rhelmer

Comment 5

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened

Reopening for clarification:

1. The the title of the bug leads me to understand that a HTTP 404 is incorrect.
- Bug title - > "Loading topcrashers with unknown product doesn't 404"

- [14:14:29.166] GET https://crash-stats.allizom.org/topcrasher/products/Camino/versions/2.0.1 [HTTP/1.1 404 NOT FOUND 233ms]

2. Should the page display an error with "Product Unrecognized?" It doesn't appear to.
- https://crash-stats.allizom.org/topcrasher/products/dude/versions/2.0.1
- https://crash-stats.allizom.org/topcrasher/products/Camino/versions/2.0.1

- https://github.com/mozilla/socorro/commit/b762e32ca20b77e03eac5e82c52e2ab18af4da67#L1R300

Comment 6

[Peter Bengtsson [:peterbe]]

Thanks for asking. No, what should happen is a 404 error which according to your last comment it correctly does. 

No, we don't want a "Product Unrecognized" there. Perhaps we should since the URL getting you there was an old bookmark or something. 

What do you think? I'm primarily interested in not getting a 500 error.

Comment 7

[Matt Brandt [:mbrandt]]

Sounds great - bumping to QA verified. A 404 is most-excellently (and definitely) better than a 500 error.

I'd vote for note adding additional error handling, I suspect our users are proficient enough to recognize when an invalid product version, etc is used.