Closed
Bug 915278
Opened 12 years ago
Closed 12 years ago
[clock] Create IndexedDB wrapper to support database upgrades/downgrades
Categories
(Firefox OS Graveyard :: Gaia::Clock, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: oconnore, Assigned: oconnore)
References
Details
Attachments
(1 file)
No description provided.
| Assignee | ||
Comment 1•12 years ago
|
||
Attachment #803151 -
Flags: review?(mike)
Comment 2•12 years ago
|
||
Any ideas why the tests are failing on TravisCI?
| Assignee | ||
Comment 3•12 years ago
|
||
Travis failure was caused by these sinon fakeTimer leaks:
https://github.com/oconnore/gaia/commit/64affcc148fdde1cf7fb2f05228fd264e3533b3f
Current failures are not related.
Comment 4•12 years ago
|
||
Comment on attachment 803151 [details] [review]
github PR
Nice work! I've left feedback on the GitHub pull request; you can re-flag me for review whenever you're ready
Attachment #803151 -
Flags: review?(mike)
| Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 803151 [details] [review]
github PR
Hi Mike, I made some changes based on your review.
Attachment #803151 -
Flags: review?(mike)
Comment 6•12 years ago
|
||
Comment on attachment 803151 [details] [review]
github PR
Looks good, Eric! I'll merge this as soon as the upstream Gaia is unlocked
Attachment #803151 -
Flags: review?(mike) → review+
Comment 7•12 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/750a94e6f4d8ff49b514735f45b5c1c999050ed5
(Delayed due to Gaia tree closure)
Nice work, Eric
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•