915372 - Inspector can only be opened once per app per connection

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. Connect the App Manager to a device
2. From My Device -> Installed Apps, start some app, like say Gallery
3. Click Debug on Gallery to open the toolbox
4. Switch to the Inspector tab
5. Close the toolbox
6. Click Debug again on the same app (Gallery)
7. You will see the Inspector tab is selected, but the actual content of the tool does not appear.  Other tools appear to work fine.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Clean up inspector front and actor when reusing connection

The changes I made in bug 912646 to keep the client connected when a remote target closes exposed a few cleanups that were missing in the inspector code path.

Previously, these weren't required since the client would go away when a toolbox is closed, but that's no longer true when you are remote.

Comment 2

[Paul Rouget [:paul]]

Can we land that?

Comment 3

[Paul Rouget [:paul]]

Push to try: https://tbpl.mozilla.org/?tree=Try&rev=fcab8ea6adcf

Comment 4

[Paul Rouget [:paul]]

Orange

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Clean up inspector front and actor when reusing connection (v2)

An additional change was needed to resolve a race condition.  Currently, when a toolbox is destroyed, the panels, host, and target are all told to destroy and they race each other. 

The complication is that the inspector panel wants to destroy the WalkerFront / WalkerActor and the target now wants to destroy the InspectorFront (which owns the WalkerFront) and the debugger connection (for local tabs only).

In this version, I've made an additional change to delay target destruction until after the panels and host are done being destroyed, in case they rely on an active connection to do their work.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=5112236ade3b

Comment 6

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/fd81593030b1

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fd81593030b1

Comment 8

[Paul Rouget [:paul]]

Comment on attachment 805486 [details] [diff] [review]
Clean up inspector front and actor when reusing connection (v2)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: can't use the inspector twice
Testing completed (on m-c, etc.): fx-team, m-c
Risk to taking this patch (and alternatives if risky): low 
String or IDL/UUID changes made by this patch: no

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ef734225adc8

Comment 10

[Petruta Horea [:phorea], Desktop QA]

Mozilla/5.0 (X11; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:28.0) Gecko/20100101 Firefox/28.0

The issue as described in Comment 0 still reproduces on latest Nightly (20131030030201) on Debugger tab.

Using the following STR it can also be seen in the Inspector tab:
1. Open an app
2. Select the Debug button
3. On toolbox select all the tabs and check that they contain data
4. Go to Console tab and close the toolbox
5. Reopen the toolbox and check again the tabs content

AR: The Inspector and Debugger tabs have no content. Please see the screencast: https://docs.google.com/file/d/0BzbDkQ2Zlg86ZklJaDZWZUNoUkk/edit?usp=sharing

Should I file new bugs for these issues? Thanks

Comment 11

[Paul Rouget [:paul]]

(In reply to petruta.rasa from comment #10)
> Mozilla/5.0 (X11; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0
> Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:28.0) Gecko/20100101
> Firefox/28.0
> 
> The issue as described in Comment 0 still reproduces on latest Nightly
> (20131030030201) on Debugger tab.
> 
> Using the following STR it can also be seen in the Inspector tab:
> 1. Open an app
> 2. Select the Debug button
> 3. On toolbox select all the tabs and check that they contain data
> 4. Go to Console tab and close the toolbox
> 5. Reopen the toolbox and check again the tabs content
> 
> AR: The Inspector and Debugger tabs have no content. Please see the
> screencast:
> https://docs.google.com/file/d/0BzbDkQ2Zlg86ZklJaDZWZUNoUkk/edit?usp=sharing
> 
> Should I file new bugs for these issues? Thanks

Yes. Please. That sounds pretty bad.

Comment 12

[Petruta Horea [:phorea], Desktop QA]

Marking as verified since the original issue is not reproducible on latest Aurora (20131028004004) and Nightly (20131030030201). Logged 933212 and 933214 for the other issues found.