Closed
Bug 915556
Opened 11 years ago
Closed 11 years ago
en-US consistency: use single unicode character … instead of ... in project.installing
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: flod, Assigned: flod)
References
Details
Attachments
(1 file)
1.56 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/mozilla-central/rev/f4f0334971ae
project.installing=Installing...
All products use the single unicode character, this should be fixed for consistency. We don't usually change the existing ID in these cases.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #803548 -
Flags: review?(paul)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → francesco.lodolo
Comment 2•11 years ago
|
||
Comment on attachment 803548 [details] [diff] [review]
bug915556.patch
I think you want to rename project.installing to project.installing2.
Attachment #803548 -
Flags: review?(paul) → review-
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 803548 [details] [diff] [review]
bug915556.patch
Review of attachment 803548 [details] [diff] [review]:
-----------------------------------------------------------------
As explained in comment 0, it's not really needed for this kind of change (see for example bug 760804).
Asked pike on IRC and got green light on not renaming the string. Reflagging for review.
Attachment #803548 -
Flags: review- → review?(paul)
Updated•11 years ago
|
Attachment #803548 -
Flags: review?(paul) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b6336472574b
FYI, you don't need to use [land-in-fx-team] anymore. Just checkin-needed works fine :)
Keywords: checkin-needed
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•