Closed Bug 915556 Opened 6 years ago Closed 6 years ago

en-US consistency: use single unicode character … instead of ... in project.installing

Categories

(DevTools :: WebIDE, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 file)

https://hg.mozilla.org/mozilla-central/rev/f4f0334971ae
project.installing=Installing...

All products use the single unicode character, this should be fixed for consistency. We don't usually change the existing ID in these cases.
Attached patch bug915556.patchSplinter Review
Attachment #803548 - Flags: review?(paul)
Assignee: nobody → francesco.lodolo
Comment on attachment 803548 [details] [diff] [review]
bug915556.patch

I think you want to rename project.installing to project.installing2.
Attachment #803548 - Flags: review?(paul) → review-
Comment on attachment 803548 [details] [diff] [review]
bug915556.patch

Review of attachment 803548 [details] [diff] [review]:
-----------------------------------------------------------------

As explained in comment 0, it's not really needed for this kind of change (see for example bug 760804).
Asked pike on IRC and got green light on not renaming the string. Reflagging for review.
Attachment #803548 - Flags: review- → review?(paul)
Attachment #803548 - Flags: review?(paul) → review+
Keywords: checkin-needed
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/b6336472574b

FYI, you don't need to use [land-in-fx-team] anymore. Just checkin-needed works fine :)
Keywords: checkin-needed
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b6336472574b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.