Allow simple variable references in includedeps files

RESOLVED FIXED in mozilla26

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla26
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
I'm going to need this in bug 907365 (not really directly, but its future-proofing is requiring it).
(Assignee)

Comment 1

4 years ago
Created attachment 803662 [details] [diff] [review]
Allow simple variable references in includedeps files
Attachment #803662 - Flags: review?(gps)

Comment 2

4 years ago
Comment on attachment 803662 [details] [diff] [review]
Allow simple variable references in includedeps files

Review of attachment 803662 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder at what point includedeps will have reinvented include :)

::: build/pymake/pymake/parser.py
@@ +409,5 @@
> +                    expansion.appendfunc(functions.VariableRef(None,
> +                        data.StringExpansion(element, None)))
> +                elif element:
> +                    expansion.appendstr(element)
> +                i += 1

Nit: Use enumerate() instead of tracking i explicitly.
Attachment #803662 - Flags: review?(gps) → review+

Comment 3

4 years ago
https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/5d83a8746631
https://hg.mozilla.org/integration/mozilla-inbound/rev/b86d7ce8d1eb
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/b86d7ce8d1eb
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.