915642 - Allow simple variable references in includedeps files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

I'm going to need this in bug 907365 (not really directly, but its future-proofing is requiring it).

Comment 1

[Mike Hommey [:glandium]]

Attachment: Allow simple variable references in includedeps files

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 803662 [details] [diff] [review]
Allow simple variable references in includedeps files

Review of attachment 803662 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder at what point includedeps will have reinvented include :)

::: build/pymake/pymake/parser.py
@@ +409,5 @@
> +                    expansion.appendfunc(functions.VariableRef(None,
> +                        data.StringExpansion(element, None)))
> +                elif element:
> +                    expansion.appendstr(element)
> +                i += 1

Nit: Use enumerate() instead of tracking i explicitly.

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/5d83a8746631
https://hg.mozilla.org/integration/mozilla-inbound/rev/b86d7ce8d1eb

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b86d7ce8d1eb