Closed Bug 915758 Opened 7 years ago Closed 7 years ago

Split out <input type=number> to be behind its own pref

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file, 1 obsolete file)

Right now <input type=number> is behind the dom.experimental_forms pref along with type=time and type=date. In order to turn it on for release without turning on time/date we'll need it to be behind its own pref.
Attached patch patch (obsolete) — Splinter Review
Attachment #803851 - Flags: review?(mounir)
Attached patch patchSplinter Review
Change to be consistent with color rather than range.
Attachment #803851 - Attachment is obsolete: true
Attachment #803851 - Flags: review?(mounir)
Attachment #803858 - Flags: review?(mounir)
Comment on attachment 803858 [details] [diff] [review]
patch

Review of attachment 803858 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good. But keep in mind that you will have to remove NS_FORM_INPUT_NUMBER from the list of experimental mobile types when it will no longer need to follow the code path related to them. Note that we might no longer need most of that code path since there is now an "InvalidInput" error.
Attachment #803858 - Flags: review?(mounir) → review+
https://hg.mozilla.org/mozilla-central/rev/60ba9b28408c
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.