Closed
Bug 915758
Opened 11 years ago
Closed 11 years ago
Split out <input type=number> to be behind its own pref
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.33 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
Right now <input type=number> is behind the dom.experimental_forms pref along with type=time and type=date. In order to turn it on for release without turning on time/date we'll need it to be behind its own pref.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #803851 -
Flags: review?(mounir)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Change to be consistent with color rather than range.
Attachment #803851 -
Attachment is obsolete: true
Attachment #803851 -
Flags: review?(mounir)
Attachment #803858 -
Flags: review?(mounir)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 803858 [details] [diff] [review]
patch
Review of attachment 803858 [details] [diff] [review]:
-----------------------------------------------------------------
Sounds good. But keep in mind that you will have to remove NS_FORM_INPUT_NUMBER from the list of experimental mobile types when it will no longer need to follow the code path related to them. Note that we might no longer need most of that code path since there is now an "InvalidInput" error.
Attachment #803858 -
Flags: review?(mounir) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•