91585 - Startup URL shows up on every browser launch (branch only)

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[racham]

Here is what I noticed with build 
[ 2001-07-19-05-0.9.2 0 07/19/01 06:44:00 am directory] I downloaded from sweetlou.

Case I :
1. Create a new profile
2. Activation window comes up.
3. Click on 'x' on the right upper corner to close the activation window
4. Browser window comes up
5. The startpage url is "http://home.netscape.com/browsers/6/su_setup61pr.html"
6. Close the browser window
7. Launch browser again
8. Click on 'x' of the activation window
9. Note that browser comes up with
"http://home.netscape.com/browsers/6/su_setup61pr.html" again
10. It happens on every subsequent launches (repeating these steps)

Case II :
1. Create a new profile
2. Activation window comes up
3. Activate without clicking on any links on activation window
4. Activation window closes
5. Browser window comes up
6. The startpage url is "http://home.netscape.com/browsers/6/su_setup.html"
7. Close the browser window
8. Launch browser again.
9. Note that browser comes up with
"http://home.netscape.com/browsers/6/su_setup.html" again
10. It happens on every subsequent launches 

Let me know if you can reproduce the above scenarios...

Comment 1

[racham]

and this happens in mozilla also from what I noticed with my debug build..

In your mozilla build,

1. Create a new profile
2. Browser launches with http://www.mozilla.org/mozorg.html
3. Close the browser
4. Launch it again
5. Browser is launched with http://www.mozilla.org/mozorg.html again


Even If I visit some other site without closing the browser immediately, 
browser still goes back to http://www.mozilla.org/mozorg.html on the next launch

In case of mozilla, on subsequent launches we should be going to
http://www.mozilla.org.
In case of commercial builds, on subsequent launches we should be going to
http://home.netscape.com.

Assinging this to Steve Morse as I think the fix in bugscape bug 4428 might have
caused this.

Comment 2

[Viswanath Ramachandran]

Bhuvan - can you confirm your hypothesis by backing the change in bugscape 4428
out in your local tree and trying again? that would help greatly in narrowing it
down!

Comment 3

[lchiang]

grace - do you see this also?  

Comment 4

[lchiang]

marking PDT+ per PDT email.

Comment 5

[racham]

I am updating my branch build. Once that is done, I can try backing out changes
made in bugscape bug 4428.

Comment 6

[Grace Bush]

I see it using Bhuvan's steps- using build 2001072006 on Win
(also see different pages since/when I test links on Activation)

Comment 7

[Viswanath Ramachandran]

Steve is going to be out of the office. Bhuvan can you own this item since we 
need urgent coverage on it. ->racham

Comment 8

[racham]

Attachment: patch backing out morse's apprunner changes

Comment 9

[racham]

Attachment: Startpage matrix in current state as exists on branch (with morse's code in there)

Comment 10

[racham]

Attachment: Startpage matrix after backing out morse's apprunner changes (i.e., with patch in this bug applied)

Comment 11

[racham]

Bugscape bug 7443 also uses this patch as part of solving startpage problems.

Jag, Seth, Vishy, please review the patch in here.

thanks
bhuvan

Comment 12

[jag (Peter Annema)]

r=jag

Comment 13

[selmer (gone)]

Bhuvan, looking at the two matrices, it seems like this only changes the
behavior of the new profile.  I assume 7443 is required to get fully correct
behavior?

Comment 14

[racham]

Yes. that's right. Cases where user activates/cancels activation without
clicking any link on activation window for a new a profile are the improvements
here.

Patch in bugscape bug 7443, improves the behavior further by doing the right
thing when user clicks on links activation window. In bug 7443, I did mention
the single case where we don't show the first page (i.e., clicking on a link on
activation window and then closing the activation window using 'x') as we don't
get a chance to make app visit the patch in that bug. So, jag is trying to come
up with a solution which can take care of all cases where user clicks on a link
on activation window.

Comment 15

[Blake Ross]

sr=blake

Comment 16

[Blake Ross]

I just checked this in on the branch.  According to the summary this is
branch-only, but didn't morse's fix go on the trunk too?

Comment 17

[Viswanath Ramachandran]

marking this fixed. this patch does not need to be applied to the trunk because 
the original apprunner changes were never put on the trunk. 

Comment 18

[Viswanath Ramachandran]

Bhuvan, Jag, Blake - thanks to you all for fixing this problem. GREAT WORK! 

Comment 19

[racham]

Blake,

Thanks for super-review and checking it in. I posted this same update yesterday
 around 17:30. Looks like the next screen was login and password, so that is
missed. So, typing this again. I planned on doing checkins yesterday evening and
when I checked my mail, I realized that you covered the checkin. Thanks again
for taking care of this.

Thanks to all those who helped us solving this bug.

bhuvan

Comment 20

[Grace Bush]

verifying on branch builds
200107230x (Win/Mac/Linux)