Closed
Bug 915853
Opened 11 years ago
Closed 11 years ago
device.js recognizes B2G UA as desktop browser
Categories
(Web Compatibility :: Site Reports, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: miketaylr, Assigned: miketaylr)
References
()
Details
"mobile" is defined as:
> device.androidPhone() or device.iphone() or device.ipod() or device.windowsPhone() or device.blackberryPhone()
So I guess we'll have to suggest `device.fxos` or similar...
https://github.com/matthewhudson/device.js
|
Assignee | |
Comment 1•11 years ago
|
||
Sent a pull request, https://github.com/matthewhudson/device.js/pull/38
|
|
Assignee | |
Comment 2•11 years ago
|
||
PR merged.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•11 years ago
|
||
Sadly I didn't account for the device id cases (zteopen, lg fireweb, etc) when I sent in the patch. These get correctly identified as mobile, but not as .fxos. Will submit another patch shortly.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
||
Updated•11 years ago
|
Status: REOPENED → ASSIGNED
|
|
Assignee | |
Comment 4•11 years ago
|
||
Actually, current master is fine. The test page just needs to update its version. I filed https://github.com/matthewhudson/device.js/issues/58.
|
|
Assignee | |
Comment 5•11 years ago
|
||
Fixed now.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Tech Evangelism → Web Compatibility
|
|
||
Updated•9 months ago
|
Component: Mobile → Site Reports
You need to log in
before you can comment on or make changes to this bug.
Description
•