device.js recognizes B2G UA as desktop browser

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: miketaylr, Assigned: miketaylr)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

"mobile" is defined as:

> device.androidPhone() or device.iphone() or device.ipod() or device.windowsPhone() or device.blackberryPhone()

So I guess we'll have to suggest `device.fxos` or similar... 

https://github.com/matthewhudson/device.js
PR merged.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Sadly I didn't account for the device id cases (zteopen, lg fireweb, etc) when I sent in the patch. These get correctly identified as mobile, but not as .fxos. Will submit another patch shortly.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Actually, current master is fine. The test page just needs to update its version. I filed https://github.com/matthewhudson/device.js/issues/58.
Fixed now.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.