Closed
Bug 915881
Opened 11 years ago
Closed 11 years ago
Allow sideloading of certified apps
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fabrice, Assigned: fabrice)
References
Details
Attachments
(1 file)
|
3.94 KB,
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
Because we want all the nice things.
Attachment #804018 -
Flags: review?(poirot.alex)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 804018 [details] [diff] [review]
sideload-certified.patch
Review of attachment 804018 [details] [diff] [review]:
-----------------------------------------------------------------
r+ with the comment addressed.
::: toolkit/devtools/server/actors/webapps.js
@@ -283,5 @@
> - if (!DOMApplicationRegistry.allowSideloadingCertified &&
> - appType == Ci.nsIPrincipal.APP_STATUS_CERTIFIED) {
> - throw new Error("Installing certified apps is not allowed.");
> - }
> - return appType;
We should remove the appType check but still keep this method that computes the appType from the manifest. It is later used to set the appStatus.
Attachment #804018 -
Flags: review?(poirot.alex) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•