915909 - SeaMonkey should make use of exif orientation when displaying attached images

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[rsx11m]

+++ This bug was initially created as a clone of Bug #877520 +++

Backend support for interpreting EXIF orientation information in JPEG images was introduced with bug 825771 by implementing the CSS3 "image-orientation" property. This works already in the browser for stand-alone images in top-level documents per bug 298619.

Images attached to e-mail and news messages still ignore the EXIF orientation information. Thunderbird added "from-image" rules in bug 877520 for their themes, this bug aims to apply those rules to SM classic and modern themes.

Comment 1

[rsx11m]

Attachment: Proposed patch

Straight-forward fix following bug 877520 attachment 797739 [details] [diff] [review]. Tested on Windows 7 with both default and classic themes using attachment 755730 [details] added to a message. The image is correctly displayed in portrait orientation in accordance with its EXIF information.

Comment 2

[Philip Chee]

I have these in my messageBody.css notes:

TB Bug 747415 - Make our css more efficient
TB Bug 877520 - Thunderbird should make use of exif orientation when displaying attached images.
Core Bug 879131 - Use prefix-less zoom-in and zoom-out CSS property values.

I think 747415 and 879131 are small enough not to warrant separate bugs.

Comment 3

[[e-mail]]

(In reply to Philip Chee from comment #2)
> I think 747415 and 879131 are small enough not to warrant separate bugs.
879131 - just about, since the affected lines are already in the patch context.
747415 - have you seen how big their patch is?

Comment 4

[rsx11m]

Attachment: Proposed patch (v2)

(In reply to [e-mail] from comment #3)
> 879131 - just about, since the affected lines are already in the patch context.
Agreed, that's easy enough to address here and those are the only instances.

> 747415 - have you seen how big their patch is?
I'll happily skip this for another patch. ;-)

Comment 5

[rsx11m]

Thanks Neil, push for comm-central please.

Comment 6

[rsx11m]

FTR: Thunderbird covered the removal of "-moz-" for zoom-* in bug 916085.

Comment 7

[Philip Chee]

> 747415 - have you seen how big their patch is?
Just the messageBody.css changes :P

Comment 8

[Philip Chee]

Pushed CLOSED TREE:
https://hg.mozilla.org/comm-central/rev/0b7a62366012

Comment 9

[rsx11m]

(In reply to Philip Chee from comment #7)
> > 747415 - have you seen how big their patch is?
> Just the messageBody.css changes :P

Ok, that would have narrowed the patch over there down significantly. Nevertheless, those changes didn't quite fit into the scope of this bug, thus maybe clone that TB bug to SM to take care of any CSS cleanup that has suite/themes counterparts as well.

Comment 10

[Stefan [:stefanh]]

> thus maybe clone that TB bug to SM to take care of any CSS cleanup that has
> suite/themes counterparts as well.

I filed bug 916478.