Closed
Bug 915958
Opened 11 years ago
Closed 11 years ago
Close media queues when we reach EOS in DecodeLoop
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: cpearce, Assigned: cpearce)
Details
Attachments
(1 file)
|
16.46 KB,
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
In every backend that we write we forget to call MediaQueue::Finish() when we reach EOS or an error occurs and decoding can't progress.
We should just call Finish() in MediaDecoderStateMachine::DecodeLoop(), so that we don't need to keep remembering to do this.
Attached patch is green:
https://tbpl.mozilla.org/?tree=Try&rev=e9df2df1e3e6
Attachment #804159 -
Flags: review?(edwin)
Comment on attachment 804159 [details] [diff] [review]
Patch: Automatically Finish() MediaQueues on EOS in DecodeLoop
YES.
Attachment #804159 -
Flags: review?(edwin) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•