Close media queues when we reach EOS in DecodeLoop

RESOLVED FIXED in mozilla26

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

Trunk
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 804159 [details] [diff] [review]
Patch: Automatically Finish() MediaQueues on EOS in DecodeLoop

In every backend that we write we forget to call MediaQueue::Finish() when we reach EOS or an error occurs and decoding can't progress.

We should just call Finish() in MediaDecoderStateMachine::DecodeLoop(), so that we don't need to keep remembering to do this.

Attached patch is green:
https://tbpl.mozilla.org/?tree=Try&rev=e9df2df1e3e6
Attachment #804159 - Flags: review?(edwin)
Comment on attachment 804159 [details] [diff] [review]
Patch: Automatically Finish() MediaQueues on EOS in DecodeLoop

YES.
Attachment #804159 - Flags: review?(edwin) → review+

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/229879d7f5f2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.