916100 - [Contacts] Taapping on the disabled merge button when there are not contacts selected to be merged make it to change its colour

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[isabelrios]

Attachment: 1980-01-14-21-37-09.png

Master 09/13 build:
Gecko-ec0b45d
Gaia-0df2b51

STR
There should be at least one contact in the contact list with Name and Phone Number.
1. Create a new contact with same phone number than the contact's phone already created.
2. On the Merge duplicates screen, unselect the contact suggested
3. Tap on the 'No contact selected' screen 

EXPECTED 
When there are no contacts selected to be merged, the button to merged should be disabled

ACTUAL
Although the button is greyed, it is possible to tap on it and it changes its colour to red while it is pressed.
Please see screenshot attached

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Associated PR.

Pull request: https://github.com/mozilla-b2g/gaia/pull/12295

Comment 2

[Jose Manuel Cantera]

Comment on attachment 806577 [details]
Associated PR.

good catch German.

thanks

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Merged in master: https://github.com/mozilla-b2g/gaia/commit/49ca8b7f90f2a67d13e621863c87797a670cf91d

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Reopening the bug since it seems we went to far with the patch and the "Merge" button appears is always disabled (although not visually) :-(

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Additional PR solving some regressions.

Pull request: https://github.com/mozilla-b2g/gaia/pull/12308

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Merged (again :-p) in master: https://github.com/mozilla-b2g/gaia/commit/676a9f08a8eacdfc47286ca1e24bf1f99faaf318

Comment 7

[isabelrios]

Verified on master 09/20 build.
Gecko-51c1780
Gaia-dce497b

Comment 8

[James Lal [:lightsofapollo]]

Uplifted 676a9f08a8eacdfc47286ca1e24bf1f99faaf318 to:
v1.2: b9852cb8161713824514284476301529ab201e75