916237 - Inspector won't connect to non-OOP B2G apps

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. Use the App Manager to connect a non-OOP app, like System
2. Go to the Inspector tab
3. It is blank
4. You have the following error in the Browser Console:

this.conn.allocID is not a function

Pool<.manage@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:689
exports.InspectorFront<.initialize@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:2245
constructor@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/heritage.js:145
TabTarget.prototype.inspector@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:263
InspectorPanel.prototype._getWalker@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/inspector/inspector-panel.js:150
InspectorPanel_open/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/inspector/inspector-panel.js:49
resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:118
then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:43
then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/core/promise.js:153
InspectorPanel_open@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/inspector/inspector-panel.js:48
Tools.inspector.build@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/main.js:113
TBOX_loadTool/onLoad@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:518

Comment 1

[Paul Rouget [:paul]]

The style editor either.

Comment 2

[Paul Rouget [:paul]]

Might be related: bug 915444

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I tried out the patch from bug 915444 on B2G, but that didn't appear to resolve the issue for me.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Enable inspector actor in b2g parent process r=paul

The exceptiong really didn't help figuring out this simple issue...
We weren't loading inspector actor in the parent process, so that any app being debugged in parent process wasn't having the inspector tab actor instanciated.

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 805382 [details] [diff] [review]
Enable inspector actor in b2g parent process r=paul

It also fix the inspector in the simulator as all apps are still in parent process.

Comment 6

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/6873763660a5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6873763660a5

Comment 8

[Paul Rouget [:paul]]

Comment on attachment 805382 [details] [diff] [review]
Enable inspector actor in b2g parent process r=paul

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: Not possible to use the inspector with some Firefox OS apps
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: no

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1eee5e8e7133

Comment 10

[Bogdan Maris, Desktop QA]

I am unable to reproduce the initial issue. Can you please verify that this is fixed on latest Aurora and latest Nightly?

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Yes, it is fixed in the latest Aurora and Nightly.

Comment 12

[Bogdan Maris, Desktop QA]

Thanks Ryan.