Closed
Bug 916321
Opened 11 years ago
Closed 11 years ago
[jsdbg2] Debugger.Object.prototype.unsafeDereference outerizes, but we should check that it does
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file)
|
1.17 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Because of the call to JSCompartment::wrap, Debugger.Object.prototype.unsafeDereference always outerizes the referent before returning it. However, this behavior should be documented, asserted, and tested.
|
Assignee | |
Comment 1•11 years ago
|
||
By the way, this is a follow-up to bug 914405.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Try push for patch I'm about to attach (or abbout to atach?):
https://tbpl.mozilla.org/?tree=Try&rev=f3894dfcb058
|
|
Assignee | |
Comment 3•11 years ago
|
||
Assignee: general → jimb
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 808347 [details] [diff] [review]
Assert that Debugger.Object.prototype.unsafeDereference outerizes inner objects.
Try push looks good.
Attachment #808347 -
Flags: review?(jorendorff)
|
||
Updated•11 years ago
|
Attachment #808347 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Flags: in-testsuite+
Target Milestone: --- → mozilla27
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•