916391 - Part of test/browser_dbg_multiple-windows.js seems to be disabled

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Boris Zbarsky [:bzbarsky]]

If you look at a log after bug 876277 landed, the log for this test looks like this:


14:55:26     INFO -  TEST-START | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js
14:55:26     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | Root actor should identify itself as a browser.
14:55:26     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | Adding tab: http://example.com/browser/browser/devtools/debugger/test/doc_script-switching-01.html
14:55:26     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | Second tab created.
14:55:26     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | Should find a tab actor for the first tab.
14:55:26     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | The first tab is selected.
14:55:26     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | Adding window: http://example.com/browser/browser/devtools/debugger/test/doc_script-switching-02.html
14:55:26     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | Second window created.
14:55:26     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | The second window is on top.
14:55:27     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | The second tab is selected.
14:55:27     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | Waiting for event: 'focus' on [object XrayWrapper [object Window]].
14:55:27     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | The first window is on top.
14:55:27     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | The first tab is selected after focusing on it.
14:55:27     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | Removing tab.
14:55:27     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | finish() was called, cleaning up...
14:55:27     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_multiple-windows.js | finished in 1365ms

Conspicuously missing is any mention of "Tab1 should be gone." or "The original tab is selected."

I assume this happens because the test got rejiggered like so:

      .then(testRemoveTab)
      .then(closeConnection)
      .then(finish)

but testRemoveTab kicks off a new async operation (listTabs)... but nothing now waits for this operation to complete.  I assume it should return a promise that's resolved when the operation completes?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Victor, this is blocking bug 874502 because the fix I had for this test before doesn't work in the new setup and the right fix will depend on how this bug gets fixed...  Please let me know ASAP if you won't be able to fix this quickly: that bug is blocking workers DOM work that people are really antsy to get landed.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Oh, and the point is that if you don't have time for this I can take a stab at it.

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Boris Zbarsky [:bz] from comment #1)

You're right. This is an easy fix.

Comment 4

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/d60477f4cb20

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d60477f4cb20