916445 - DataStore.sync method

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Documentation about this method can be found here: https://wiki.mozilla.org/WebAPI/DataStore

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

The DataStoreCursor implements a basic state machine. Documentation of the workflow is at the top of the source code.
The mochitest recreates all the scenarios I was able to imagine.

Comment 2

[(no longer active)]

Comment on attachment 804881 [details] [diff] [review]
patch

Review of attachment 804881 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/datastore/DataStoreCursor.jsm
@@ +8,5 @@
> +
> +this.EXPORTED_SYMBOLS = ['DataStoreCursor'];
> +
> +function debug(s) {
> +  dump('DEBUG DataStoreCursor: ' + s + '\n');

Please make this conditional on a variable.

@@ +76,5 @@
> +  return new aWindow.DOMError(aEvent.target.error.name);
> +}
> +
> +/* DataStoreCursor object */
> +function DataStoreCursor(aWindow, aDataStore, aRevisionId) {

this.DataStoreCursor here and below.

@@ +280,5 @@
> +        self.stateMachine(aStore, aRevisionStore, aResolve, aReject);
> +        return;
> +      }
> +
> +      // Some revision has to be send.

Nit: sent.

::: dom/datastore/tests/test_sync.html
@@ +116,5 @@
> +  function finish() {
> +    SimpleTest.finish();
> +  }
> +
> +  SpecialPowers.Cu.import("resource://gre/modules/DataStoreChangeNotifier.jsm");

This doesn't seem to be needed AFAICT.

::: dom/webidl/DataStore.webidl
@@ +78,5 @@
> +
> +dictionary DataStoreTask {
> +  DOMString revisionId;
> +
> +  IDBCursorDirection operation;

I think you meant DataStoreOperation here, right?  (Please also fix the wiki page)

Comment 3

[Andrea Marchesini [:baku]]

Attachment: patch

testing it on try.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=9f62fcf905b3

Comment 5

[Andrea Marchesini [:baku]]

Attachment: patch

rebased

Comment 6

[Andrea Marchesini [:baku]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/b694df7e2faa

Comment 7

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/213bf2a49fd9

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/213bf2a49fd9