916451 - browser_cmd_addon.js | html output for addon disable Test_Plug-in_1.0.0.0 - Got Test Plug-in 1.0.0.0 is already disabled., expected Test Plug-in 1.0.0.0 disabled

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

During browser_cmd_addon.js I get the following failure:
html output for addon disable Test_Plug-in_1.0.0.0 - Got Test Plug-in 1.0.0.0 is already disabled., expected Test Plug-in 1.0.0.0 disabled

Interestingly, if I check just before receiving this message then the plugin is still enabled. If I then try to disable it via GCLI I am told that it is already disabled.

I haven't seen this on try and tests do run very quickly on my setup so maybe this is the cause.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: browser_cmd_addon_js-already-916451.patch

It seems that on my laptop the Test Plugin is marked as click to activate. This means that it is half disabled.

This simple patch checks for addon.userDisabled === AddonManager.STATE_ASK_TO_ACTIVATE and acts appropriately.

Try:
https://tbpl.mozilla.org/?tree=Try&rev=31f2208dedbe

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 805237 [details] [diff] [review]
browser_cmd_addon_js-already-916451.patch

Joe is away, assigning to harth.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/b203caf12b57

Just a friendly reminder that your commit message should be summarizing what the patch is actually doing, not restating the bug title :)

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b203caf12b57