Closed Bug 916454 Opened 7 years ago Closed 7 years ago

Browser hanging when reloading some pages while the debugger is open and source maps are enabled

Categories

(DevTools :: Debugger, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: vporof, Assigned: fitzgen)

Details

Attachments

(2 files)

Attached file log.txt
STR:

1. Go to http://todomvc.com/
2. Open debugger, wait for sources to be shown
3. Refresh

It takes around 20 seconds for the sources to finish fetching. The browser freezes in the meantime.
Refreshing is instant if I disable source maps via the gear menu. Nick?
Flags: needinfo?(nfitzgerald)
Backing out bug 914930 and bug 762761 doesn't fix this FWIW.
Summary: Browser hanging when reloading some pages while the debugger is open → Browser hanging when reloading some pages while the debugger is open and source maps are enabled
I can reproduce, and verify that when source maps aren't enabled it doesn't happen. Will look into this.
Assignee: nobody → nfitzgerald
Flags: needinfo?(nfitzgerald)
Priority: -- → P2
I tried to upload a profile, but it is too big for bugzilla to accept it.

The culprit is parsing the mappings, which I think we can lazily delay until we actually query for a source mapped location. However, that will still cause a hang, just later on down the line.

Might need to change the SourceMapConsumer interface, let more stuff be async and put parsing in a yielding loop.
This patch delays the parsing of a source map's mappings until queried for a source location.
Attachment #812360 - Flags: review?(past)
Comment on attachment 812360 [details] [diff] [review]
bug-916454-source-maps-reload-hang.patch

Review of attachment 812360 [details] [diff] [review]:
-----------------------------------------------------------------

I have to say Nightly no longer seems to hang with the STR in comment 0, so I'm guessing something else must have fixed this, but the change in the patch seems reasonable and works fine in my testing.
Attachment #812360 - Flags: review?(past) → review+
Scratch that, I forgot that my main browser on Linux is the stable version of Firefox. The bug is still there on Nightly without this patch.
https://hg.mozilla.org/mozilla-central/rev/1f6acfcba58f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.