If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

memory reporting code in harness.js is broken

RESOLVED FIXED

Status

Add-on SDK
General
P3
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Gavin, Assigned: erikvold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

See bug 910517 comment 17.
(see also: bug 592774)

Updated

4 years ago
Priority: -- → P3
Gavin why should the memory reporting be removed?  can it not be fixed?
Flags: needinfo?(gavin.sharp)
Created attachment 8358204 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1338#attch-to-bugzilla

Pointer to Github pull-request
Attachment #8358204 - Flags: review?(gavin.sharp)
Attachment #8358204 - Flags: review?(dtownsend+bugmail)
Assignee: nobody → evold
Comment on attachment 8358204 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1338#attch-to-bugzilla

Actually I just need the one review.
Attachment #8358204 - Flags: review?(gavin.sharp)
I don't know any more than what's in the comments in bug 910517 - hasn't been updated to keep in sync with API changes, etc.
Flags: needinfo?(gavin.sharp)
ok afaict the API was changed, and my patch does fix the bustage.
Summary: memory reporting code in harness.js is broken, should be removed → memory reporting code in harness.js is broken
Attachment #8358204 - Flags: review?(dtownsend+bugmail) → review+

Comment 7

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/3e40838fb13377f2c070e53117cbff1d7cb76c0f
Bug 916501 - memory reporting code in harness.js is broken
Bug 592774 - Re-enable Jetpack's memory debugging infrastructure test

Fixed the --profile-memory option and re-enabled the test-memory.js test

https://github.com/mozilla/addon-sdk/commit/9a83c77c39e13088333614285ffad772a3e97c04
Merge pull request #1338 from erikvold/916501

Bug 916501 - memory reporting code in harness.js is broken r=@Mossop
Blocks: 960771
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.