Closed
Bug 916501
Opened 12 years ago
Closed 12 years ago
memory reporting code in harness.js is broken
Categories
(Add-on SDK Graveyard :: General, defect, P3)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Gavin, Assigned: evold)
References
Details
Attachments
(1 file)
|
Reporter | |
Comment 1•12 years ago
|
||
(see also: bug 592774)
Priority: -- → P3
|
Assignee | |
Comment 2•12 years ago
|
||
Gavin why should the memory reporting be removed? can it not be fixed?
Flags: needinfo?(gavin.sharp)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8358204 -
Flags: review?(gavin.sharp)
Attachment #8358204 -
Flags: review?(dtownsend+bugmail)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → evold
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 8358204 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1338#attch-to-bugzilla
Actually I just need the one review.
Attachment #8358204 -
Flags: review?(gavin.sharp)
|
|
Reporter | |
Comment 5•12 years ago
|
||
I don't know any more than what's in the comments in bug 910517 - hasn't been updated to keep in sync with API changes, etc.
Flags: needinfo?(gavin.sharp)
|
|
Assignee | |
Comment 6•12 years ago
|
||
ok afaict the API was changed, and my patch does fix the bustage.
|
|
Assignee | |
Updated•12 years ago
|
Summary: memory reporting code in harness.js is broken, should be removed → memory reporting code in harness.js is broken
|
||
Updated•12 years ago
|
Attachment #8358204 -
Flags: review?(dtownsend+bugmail) → review+
|
||
Comment 7•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/3e40838fb13377f2c070e53117cbff1d7cb76c0f
Bug 916501 - memory reporting code in harness.js is broken
Bug 592774 - Re-enable Jetpack's memory debugging infrastructure test
Fixed the --profile-memory option and re-enabled the test-memory.js test
https://github.com/mozilla/addon-sdk/commit/9a83c77c39e13088333614285ffad772a3e97c04
Merge pull request #1338 from erikvold/916501
Bug 916501 - memory reporting code in harness.js is broken r=@Mossop
|
||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•