Closed Bug 916517 Opened 11 years ago Closed 6 years ago

[mozprofile] rectify DEFAULT_PORTS to be actual default ports, not proxied ports

Categories

(Testing :: Mozbase, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: k0scist, Unassigned)

Details

The websocket port is messed up in mozprofile; it is (wrongly)
set to the SSL proxy setting; see:

- https://github.com/mozilla/mozbase/blob/master/mozprofile/mozprofile/permissions.py#L27

vs

- http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in?rev=a3e34b989ebe#52

- https://github.com/mozilla/mozbase/commit/43f9510e3d58bfed32790c82a57edac5f928474d

Diffing the generated ssltunnel.cfg files apropos the patches for bug
746243 gives one significant difference:

diff pre/profile/ssltunnel.cfg now/profile/ssltunnel.cfg
....
< websocketserver:127.0.0.1:9988
---
> websocketserver:127.0.0.1:4443

The key is that ssltunnel acts as as proxy:

http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/ssltunnel/ssltunnel.cpp#411

See also: https://bugzilla.mozilla.org/show_bug.cgi?id=851292 and
https://github.com/mozilla/mozbase/commit/ddab19ab677652d23023c6f11752c86163037da3

It is MHO that mozprofile should use the default values as currently
are set in automation.py.in currently,

http://hg.mozilla.org/mozilla-central/file/655ac375b1c7/build/automation.py.in#l50

and that `mozprofile.permissions`'s `pac_prefs` should be called with
the downstream -- that is, proxied -- port values which is what is
currently in `permission.py`'s `DEFAULT_PORTS`.

See also bug 899221 about fixing the mozprofile proxy API and
documentation which would have made troubleshooting this much easier.

Ref: https://bugzilla.mozilla.org/show_bug.cgi?id=746243#c81
Mass closing bugs with no activity in 2+ years. If this bug is important to you, please re-open.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.