Closed Bug 916520 Opened 6 years ago Closed 6 years ago

Rename nsClientRect(List) to mozilla::dom::DOMRect(List)

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(1 file, 1 obsolete file)

I think we've reached a consensus to rename ClientRect to DOMRect, but I'm still waiting for that to be officially recorded.

Anyway, I have a patch.
Attached patch fixSplinter Review
This patch also moves the implementation from content/html/content/src to content/base/src.
Attachment #804978 - Flags: review?(Ms2ger)
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #0)
> I think we've reached a consensus to rename ClientRect to DOMRect, but I'm
> still waiting for that to be officially recorded.

This has happened now.
Comment on attachment 807035 [details] [diff] [review]
Part 2: Make DOMRectList an ArrayClass

bz already landed this.
Attachment #807035 - Attachment is obsolete: true
Attachment #807035 - Flags: review?(Ms2ger)
Attachment #804978 - Flags: review?(Ms2ger) → review?(khuey)
Comment on attachment 804978 [details] [diff] [review]
fix

Review of attachment 804978 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits picked

::: content/base/src/DOMRect.cpp
@@ +58,3 @@
>  
>  
>  NS_IMETHODIMP    

while you're here can you remove the extra whitespace after NS_IMETHODIMP?

@@ +63,5 @@
>    *aLength = Length();
>    return NS_OK;
>  }
>  
>  NS_IMETHODIMP    

here too.

::: content/base/src/DOMRect.h
@@ +151,5 @@
>    nsCOMPtr<nsISupports> mParent;
>  };
>  
> +}
> +}

nit: please add // namespace foo comments here.

::: dom/webidl/moz.build
@@ +47,5 @@
>      'ChannelSplitterNode.webidl',
>      'CharacterData.webidl',
>      'ChildNode.webidl',
> +    'DOMRect.webidl',
> +    'DOMRectList.webidl',

Please keep this list in alphabetical order.
Attachment #804978 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/8b94cd262ef5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.