916520 - Rename nsClientRect(List) to mozilla::dom::DOMRect(List)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think we've reached a consensus to rename ClientRect to DOMRect, but I'm still waiting for that to be officially recorded.

Anyway, I have a patch.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This patch also moves the implementation from content/html/content/src to content/base/src.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 2: Make DOMRectList an ArrayClass

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #0)
> I think we've reached a consensus to rename ClientRect to DOMRect, but I'm
> still waiting for that to be officially recorded.

This has happened now.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 807035 [details] [diff] [review]
Part 2: Make DOMRectList an ArrayClass

bz already landed this.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 804978 [details] [diff] [review]
fix

Review of attachment 804978 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits picked

::: content/base/src/DOMRect.cpp
@@ +58,3 @@
>  
>  
>  NS_IMETHODIMP    

while you're here can you remove the extra whitespace after NS_IMETHODIMP?

@@ +63,5 @@
>    *aLength = Length();
>    return NS_OK;
>  }
>  
>  NS_IMETHODIMP    

here too.

::: content/base/src/DOMRect.h
@@ +151,5 @@
>    nsCOMPtr<nsISupports> mParent;
>  };
>  
> +}
> +}

nit: please add // namespace foo comments here.

::: dom/webidl/moz.build
@@ +47,5 @@
>      'ChannelSplitterNode.webidl',
>      'CharacterData.webidl',
>      'ChildNode.webidl',
> +    'DOMRect.webidl',
> +    'DOMRectList.webidl',

Please keep this list in alphabetical order.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b94cd262ef5

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8b94cd262ef5