916609 - WebRTC permission UI broken on Fx26 ("browser is not defined)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Must have been landed and uplifted recently...  Beta (24) is not affected.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

E/GeckoConsole(10112): [JavaScript Error: "ReferenceError: browser is not defined" {file: "chrome://browser/content/WebrtcUI.js" line: 84}]

(on Aurora)

Comment 2

[Aaron Train [:aaronmt]]

Regression from http://hg.mozilla.org/mozilla-central/rev/cf373e408a6b via bug 882145

Specifically http://hg.mozilla.org/mozilla-central/diff/cf373e408a6b/browser/modules/webrtcUI.jsm

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Ummmm... bug 882145 is only on central, not Aurora

Comment 4

[Aaron Train [:aaronmt]]

This is reproducible (for me) on mozilla-central (Nightly) 09/15 only. I just installed Aurora (09/15) and am not seeing any issue.

Comment 5

[Jason Smith [:jsmith]]

We need to backout bug 882145 then if that's the confirmed regression.

Comment 6

[Jason Smith [:jsmith]]

Confirmed the same thing Aaron saw - reproduces on Fx26 Nightly, doesn't reproduce on Fx25 Aurora.

Comment 7

[Jason Smith [:jsmith]]

I can confirm also that this was working in yesterday's nightly in the build here:

ftp://ftp.mozilla.org/pub/mobile/tinderbox-builds/mozilla-central-android/1379154724/

I think Aaron is right - this looks like a regression from bug 882145.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Looks like bug 882145 updated the desktop UI but the Android fork of the UI (which apparently has no tests??) needs similar changes.

There's no reason to back anything out.  We just need to patch http://hg.mozilla.org/mozilla-central/file/9366ee039645/mobile/android/chrome/content/WebrtcUI.js#l76 with a patch like http://hg.mozilla.org/mozilla-central/diff/cf373e408a6b/browser/modules/webrtcUI.jsm

And the add a test, for goodness' sake.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c833bcf12ad8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Bug 882145 backed out.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: This should do it

This leaves the non-handling of .picture as it was.

And again, this needs tests; if it's not tested a Tinderbox, it's not reasonable to expect people to not break it, or to magically know when it's fixed..

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Apparently both my android devices got "stuck" on Aurora 25a2 around or on 8/2; and apparently gUM was broken in Aurora on that rev.  (I normally run nightly, and I was also testing Beta in the run-up to release, but not Aurora.)

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c833bcf12ad8

Comment 14

[Jason Smith [:jsmith]]

No longer need to track since the patch that regressed this was backed out.

We might need to move this patch attached here over to bug 882145.

Comment 15

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 805064 [details] [diff] [review]
This should do it

Thanks guys for acting so quickly on this, and bz for the quick patch!

Since this issue has been closed as fixed, I've moved the patch over to bug 882145 as jsmith suggested.

My bad for not noticing there were two webrtcUI files :-(