join_activity_entries doesn't reconstitute text with commas correctly.

RESOLVED FIXED in Bugzilla 4.4

Status

()

Bugzilla
Bugzilla-General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Simon Green, Assigned: Simon Green)

Tracking

Bugzilla 4.4
Bug Flags:
approval +
approval4.4 +

Details

Attachments

(1 attachment, 1 obsolete attachment)

595 bytes, patch
glob
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 805105 [details] [diff] [review]
v1 patch

If you update a text field with the following "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo, consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."

in the history and e-mail notification, there will be spaced before the commas. This is because of the way that find_wrap_point works. This patch should fix that problem.

  -- simon
(Assignee)

Updated

5 years ago
Assignee: general → sgreen
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 4.4
(Assignee)

Updated

5 years ago
Attachment #805105 - Flags: review?(gerv)

Comment 1

5 years ago
Comment on attachment 805105 [details] [diff] [review]
v1 patch

>     # All other fields get a space
>-    if (substr($new_change, 0, 1) eq ' ') {
>+    if (substr($new_change, 0, 1) eq ',' || substr($new_change, 0, 1) eq ' ') {

The comment explicitly says that *all* other fields get a space. So either the comment is wrong or the patch is incorrect. In both cases must something be fixed.
Attachment #805105 - Flags: review?(gerv) → review-
(Assignee)

Comment 2

5 years ago
Created attachment 805111 [details] [diff] [review]
v2 patch

Fixed the comment.
Attachment #805105 - Attachment is obsolete: true
Attachment #805111 - Flags: review?(gerv)
(Assignee)

Updated

5 years ago
Attachment #805111 - Flags: review?(gerv) → review?(glob)
Comment on attachment 805111 [details] [diff] [review]
v2 patch

r=glob
Attachment #805111 - Flags: review?(glob) → review+
Flags: approval?
Flags: approval4.4?
(Assignee)

Comment 5

5 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.4/                         
modified Bugzilla/Util.pm
Committed revision 8634.                                                       

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Util.pm
Committed revision 8808.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.