916633 - join_activity_entries doesn't reconstitute text with commas correctly.

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Simon Green]

Attachment: v1 patch

If you update a text field with the following "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo, consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."

in the history and e-mail notification, there will be spaced before the commas. This is because of the way that find_wrap_point works. This patch should fix that problem.

  -- simon

Comment 1

[Frédéric Buclin]

Comment on attachment 805105 [details] [diff] [review]
v1 patch

>     # All other fields get a space
>-    if (substr($new_change, 0, 1) eq ' ') {
>+    if (substr($new_change, 0, 1) eq ',' || substr($new_change, 0, 1) eq ' ') {

The comment explicitly says that *all* other fields get a space. So either the comment is wrong or the patch is incorrect. In both cases must something be fixed.

Comment 2

[Simon Green]

Attachment: v2 patch

Fixed the comment.

Comment 3

[:glob ✱]

Comment on attachment 805111 [details] [diff] [review]
v2 patch

r=glob

Comment 5

[Simon Green]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.4/                         
modified Bugzilla/Util.pm
Committed revision 8634.                                                       

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Util.pm
Committed revision 8808.