2.16 KB, text/html
15.87 KB, text/plain
1.74 KB, patch
|Details | Diff | Splinter Review|
Created attachment 805180 [details] crash.html The attached testcase crashes the nightly ASAN build. It require domFuzzLite3. ASAN output attached in stack.txt.
I'll take a look at this this week.
Created attachment 810312 [details] [diff] [review] patch Bring back the pre-EventHandler behavior
Comment on attachment 810312 [details] [diff] [review] patch r=me, but how are we getting a null boundHandler here? Is the JSObjectFromInterface failing? Seems like the only way that could happen...
We end up to BindCompiledEventHandler when mIsInitialized is false. nsJSContext hasn't been unlinked yet, so we're dealing with a context which initialization somehow failed.
Comment on attachment 810312 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): I think Bug 807226 User impact if declined: crashes, possibly exploitable Testing completed (on m-c, etc.): NA Risk to taking this patch (and alternatives if risky): Should be safe. Setting a member variable explicitly to null String or IDL/UUID changes made by this patch: NA
Comment on attachment 810312 [details] [diff] [review] patch sec-approval+ for trunk. As you say, this looks pretty safe so I'm giving it branch approval elsewhere for after it makes it into trunk and things are green. Is B2G affected?
I have no idea which branch b2g uses these days, so I don't know whether it is affected. b2g-18 shouldn't be.
https://hg.mozilla.org/releases/mozilla-aurora/rev/a684bd944d90 https://hg.mozilla.org/releases/mozilla-beta/rev/e57b395d27d3 https://hg.mozilla.org/releases/mozilla-esr24/rev/79e83c7512d5
Hi Nils - I'm not able to recreate the crash with an ASan build from 2013-09-16 and the domFuzz extension. Would you mind trying this on a recent build to verify that we've indeed fixed it? Any branch. Thank you.
Hi Matt, I can confirm that this testcase doesn't crash anymore in the latest ASAN build. I will keep a look out for similar crashes in my next fuzzing run.
Thank you, Nils.