Closed Bug 916698 Opened 6 years ago Closed 6 years ago

[app manager] 2 connect buttons

Categories

(DevTools :: WebIDE, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: paul, Assigned: paul)

References

Details

Attachments

(1 file)

I messed up a merge.
Attached patch Patch v1Splinter Review
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #805203 - Flags: review+
Keywords: checkin-needed
Whiteboard: [land-in-fx-team]
Comment on attachment 805203 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 912887
User impact if declined: In the app manager, 2 connect buttons instead of one
Testing completed (on m-c, etc.): local
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: no
Attachment #805203 - Flags: approval-mozilla-aurora?
Comment on attachment 805203 [details] [diff] [review]
Patch v1

Not sure what's the status of the uplift... let's wait.
Attachment #805203 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/integration/fx-team/rev/b43686865956
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b43686865956
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Whiteboard: [needed-in-aurora-26]
Target Milestone: Firefox 26 → ---
errr...this landed ahead of the merge?
https://hg.mozilla.org/releases/mozilla-aurora/rev/b43686865956

Please don't reset the target milestone as it specifically tracks when a patch lands on m-c.
Whiteboard: [needed-in-aurora-26]
Target Milestone: --- → Firefox 26
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.