916729 - [Async shutdown] Handle exceptions

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

If |condition| is a function and if its evaluation throws an error, this completely destroys AsyncShutdown. We need to fix this.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Handle exceptions in |condition|

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Handle exceptions in |condition|

Same one, with the patch.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 805260 [details] [diff] [review]
Handle exceptions in |condition|

Review of attachment 805260 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.  Can we have a testcase, too?

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Handle exceptions in |condition|, v2

Same one, with a trivial test.
Try: https://tbpl.mozilla.org/?tree=Try&rev=6fc4bb40f22c

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: Handle exceptions in |condition|, v3

Same one, without a syntax error in the test.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/476f2fb1d0b4

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

Aww crap. You put the wrong bug number in the patch :(

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Try: https://tbpl.mozilla.org/?tree=Try&rev=705466f7f2d8

Comment 9

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 805368 [details] [diff] [review]
Handle exceptions in |condition|, v3

Since froydnj is not very available at the moment and since I have just added a few tests since the r+, I'll just carry over that r+.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/d4fcebcd1d21

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d4fcebcd1d21