Closed Bug 916740 Opened 6 years ago Closed 6 years ago

Keyboard.jsm is not exposed to b2g's shell.js

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

x86
macOS
defect
Not set

Tracking

(blocking-b2g:koi+, firefox25 wontfix, firefox26 fixed, firefox27 fixed, b2g-v1.2 fixed)

RESOLVED FIXED
1.2 C2(Oct11)
blocking-b2g koi+
Tracking Status
firefox25 --- wontfix
firefox26 --- fixed
firefox27 --- fixed
b2g-v1.2 --- fixed

People

(Reporter: janjongboom, Assigned: janjongboom)

References

Details

(Whiteboard: QAregressexclude)

Attachments

(1 file, 1 obsolete file)

As seen in bug 912951, Keyboard.jsm is not exposed to shell.js in b2g.

09-16 17:47:10.761: E/GeckoConsole(1157): [JavaScript Error: "Keyboard is undefined" {file: "chrome://browser/content/shell.js" line: 1075}]

Breaks supportSwitching API on device. Works on Fx Nightly because we use a different shell.js there.
Attached patch 916740.diff (obsolete) — Splinter Review
:kanru, :yxl is on holiday so assigning this to you. The change in Keyboard.jsm is basically a backport from bug 906096 (see his last comments there about this), the change in shell.js was a mistake of mine that slipped through and realized that only when tested (only shows up on device, not in Fx nightly).
Assignee: nobody → janjongboom
Attachment #805252 - Flags: review?(kchen)
Blocks: 912951
Comment on attachment 805252 [details] [diff] [review]
916740.diff

Review of attachment 805252 [details] [diff] [review]:
-----------------------------------------------------------------

Do we have test for this?

::: b2g/chrome/content/shell.js
@@ +1080,1 @@
>      Keyboard.setLayouts(data.layouts);

Rename 'data' to 'detail' to avoid confusion in the future.

::: b2g/components/Keyboard.jsm
@@ +16,5 @@
>  
>  XPCOMUtils.defineLazyServiceGetter(this, "ppmm",
>    "@mozilla.org/parentprocessmessagemanager;1", "nsIMessageBroadcaster");
>  
> +let Keyboard = this.Keyboard = {

this.Keyboard = {

And later

this.Keyboard.init();
Attachment #805252 - Flags: review?(kchen)
(In reply to Kan-Ru Chen [:kanru] from comment #2)
> Do we have test for this?
Nope
(In reply to Jan Jongboom [:janjongboom] from comment #3)
> (In reply to Kan-Ru Chen [:kanru] from comment #2)
> > Do we have test for this?
> Nope

I wish we had one if it's not too hard. If it could be tested after we land bug 906096 then let's do it later.
Attached patch Gecko patch v2Splinter Review
Attachment #805252 - Attachment is obsolete: true
Attachment #805893 - Flags: review?(kchen)
Attachment #805893 - Flags: review?(kchen) → review+
blocking-b2g: --- → koi?
Keywords: checkin-needed
Blocks koi feature, so koi?
Thanks Kan-Ru for quick review by the way :-)
https://hg.mozilla.org/mozilla-central/rev/d928eabce271
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Need uplift.
blocking-b2g: koi? → koi+
Whiteboard: checkin-needed
Keywords: checkin-needed
Whiteboard: checkin-needed
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #10)
> Need uplift.

FWIW, I query for koi+ to uplift (just like leo+ etc), so checkin-needed isn't needed :)
Whiteboard: QAregressexclude
You need to log in before you can comment on or make changes to this bug.