916740 - Keyboard.jsm is not exposed to b2g's shell.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Jan Jongboom [:janjongboom] (inactive)]

As seen in bug 912951, Keyboard.jsm is not exposed to shell.js in b2g.

09-16 17:47:10.761: E/GeckoConsole(1157): [JavaScript Error: "Keyboard is undefined" {file: "chrome://browser/content/shell.js" line: 1075}]

Breaks supportSwitching API on device. Works on Fx Nightly because we use a different shell.js there.

Comment 1

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: 916740.diff

:kanru, :yxl is on holiday so assigning this to you. The change in Keyboard.jsm is basically a backport from bug 906096 (see his last comments there about this), the change in shell.js was a mistake of mine that slipped through and realized that only when tested (only shows up on device, not in Fx nightly).

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 805252 [details] [diff] [review]
916740.diff

Review of attachment 805252 [details] [diff] [review]:
-----------------------------------------------------------------

Do we have test for this?

::: b2g/chrome/content/shell.js
@@ +1080,1 @@
>      Keyboard.setLayouts(data.layouts);

Rename 'data' to 'detail' to avoid confusion in the future.

::: b2g/components/Keyboard.jsm
@@ +16,5 @@
>  
>  XPCOMUtils.defineLazyServiceGetter(this, "ppmm",
>    "@mozilla.org/parentprocessmessagemanager;1", "nsIMessageBroadcaster");
>  
> +let Keyboard = this.Keyboard = {

this.Keyboard = {

And later

this.Keyboard.init();

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

(In reply to Kan-Ru Chen [:kanru] from comment #2)
> Do we have test for this?
Nope

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Jan Jongboom [:janjongboom] from comment #3)
> (In reply to Kan-Ru Chen [:kanru] from comment #2)
> > Do we have test for this?
> Nope

I wish we had one if it's not too hard. If it could be tested after we land bug 906096 then let's do it later.

Comment 5

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Gecko patch v2

Comment 6

[Jan Jongboom [:janjongboom] (inactive)]

Blocks koi feature, so koi?

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

Thanks Kan-Ru for quick review by the way :-)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d928eabce271

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d928eabce271

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Need uplift.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #10)
> Need uplift.

FWIW, I query for koi+ to uplift (just like leo+ etc), so checkin-needed isn't needed :)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2c4b019897b6