916812 - Enable tiling on mac

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Benoit Girard (:BenWa)]

I ran with tiling on mac with OMTC enabled this weekend and found that it worked well. However we're still not backing tiles by a Quartz surface which causes a font rendering regressions.

Comment 1

[Florian Bender]

Benoit, OMTC on Mac is basically done, do you want to revisit this bug now?

Comment 2

[Benoit Girard (:BenWa)]

I have been working on bug 949573 but it may take some time with the priorities.

Comment 3

[Benoit Girard (:BenWa)]

Attachment: Part 1: RenderTile should be private

Comment 4

[Benoit Girard (:BenWa)]

checkin needed so we don't trigger a full run of test for just this trivial patch.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

In my quest to ban leave-open bugs, I suggest that you not land this patch until the rest of the patches have been posted and reviewed. It doesn't look like is that critical to get into the tree, and having patches for a single bug split across trains (as seems to happen frequently with leave-open bugs) is very annoying and makes things hard to track.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0382e390a95

In the future, please make sure the patch has commit information included when setting checkin-needed. Thanks!

Comment 7

[Benoit Girard (:BenWa)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)

I didn't see this message on time. Ideally we should just have better rules with reducing the overhead of check-in these small fixes (file a bug, get a review, run a full host of test in inbound) just to switch something from public->private. As-is there are no good solution.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0382e390a95

Comment 9

[Benoit Girard (:BenWa)]

Fixed elsewhere. I don't have the bug number handy.