916816 - New Google Maps rendering glitch

Status: VERIFIED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Alice0775 White]

Attachment: screen shot

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/9366ee039645
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130915030208

This is similar Bug 915301 but, Bug 915301 did not fix the problem.
The glitch is still existing.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Can't reproduce locally on Linux x64.

Which platform are you running? Windows x64? There might issues on ARM, but the patches for bug 915301 and bug 915495 should have solved major glitches on x64 and x86. I will try a debug build to run the checks on Google Maps.

Comment 2

[Alice0775 White]

(In reply to Benjamin Bouvier [:bbouvier] from comment #1)
> Can't reproduce locally on Linux x64.
> 
> Which platform are you running? Windows x64? There might issues on ARM, but
> the patches for bug 915301 and bug 915495 should have solved major glitches
> on x64 and x86. I will try a debug build to run the checks on Google Maps.

See Build Identifier in comment #0
Nightly26.0a1 win32 build running on Windows7 x64.

Comment 3

[Alice0775 White]

WAIT,
It seems another regression.

Comment 4

[Alice0775 White]

The regression range in comment #0 is wrong. (Sorry :bbouvier)
The correct regression rabge is as follows.

There are 2 regression
#1 Rendering glitch while zoom in/out
   Most of the glitch disappear immediately.
#2 Rendering glitch while zoom in/out and the glitch remain.


#1 Regression window
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/2d06025ea63d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130813150135
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/46f7b11d2594
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130813151137
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2d06025ea63d&tochange=46f7b11d2594
Regressed by:
46f7b11d2594	Guillaume Abadie — bug 900767 - Implement the WebGL extension ANGLE_instanced_arrays - r=jgilbert


#2 Regression window
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/2be3551a5d80
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130906171346
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/356866ae2f68
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130906172546
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2be3551a5d80&tochange=356866ae2f68
Regressed by:
356866ae2f68	Jeff Gilbert — Bug 883478 - Update ANGLE to pull from 13-08-02. r=upstream,bjacob,bas

Comment 5

[James Darpinian]

Chrome had this bug too, turns out it's a bug in ANGLE which has been recently fixed: https://code.google.com/p/angleproject/issues/detail?id=467

ANGLE_instanced_arrays support should be disabled until ANGLE can be updated with the fix. This is causing crashes for me, so it could be a security issue (https://crash-stats.mozilla.com/report/index/8c066237-e2ac-426b-8356-841ef2130916)

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: patch: Disable divisor support on ANGLE

Comment 7

[Kelsey Gilbert [:jgilbert]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b18761961ffd

Comment 8

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 805777 [details] [diff] [review]
patch: Disable divisor support on ANGLE

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 883478
User impact if declined: Broken rendering on Google Maps, etc.
Testing completed (on m-c, etc.): on m-i
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b18761961ffd

Comment 10

[Robert Kaiser]

This is said to fix the highly visible crash in bug 921196, I hope this gets uplifted to Aurora soon.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/be48daf28d42

Comment 12

[Bogdan Maris, Desktop Test Engineering]

I am not able to reproduce the bug on the build from comment 0. Alice can you verify this is fixed on latest Aurora?

Comment 13

[Alice0775 White]

I cannot also reproduce the problem on the bad build.
Probably the site modified something on their side.

Anyway, I can verify the problem is not happen on the latest Aurora26.0a2 anymore.

Comment 14

[Bogdan Maris, Desktop Test Engineering]

Thanks Alice.

Comment 15

[Tracy Walker [:tracy]]

verified with Nightly build 20131024030204 on win 7