Closed
Bug 916909
Opened 12 years ago
Closed 12 years ago
remove/update stray NS_HOLD_JS_OBJECTS and NS_DROP_JS_OBJECTS
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: deian, Assigned: deian)
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
The NS_HOLD_JS_OBJECTS and NS_DROP_JS_OBJECTS still expand to nsContentUtils::HoldJSObjects and nsContentUtils::DropJSObjects:
https://mxr.mozilla.org/mozilla-central/source/content/base/public/nsContentUtils.h#2190
but as I understand, we're now using mozilla::HoldJSObjects and mozilla::DropJSObjects instead.
Should we update nsContentUtils or just remove those macros?
|
||
Updated•12 years ago
|
Flags: needinfo?(continuation)
|
||
Comment 1•12 years ago
|
||
Oops! Yeah, the macros should be removed. Thanks for noticing.
Flags: needinfo?(continuation)
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #805472 -
Flags: review?(continuation)
|
|
||
Updated•12 years ago
|
Attachment #805472 -
Flags: review?(continuation) → review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 3•12 years ago
|
||
Assignee: nobody → deian
Keywords: checkin-needed
|
|
||
Comment 4•12 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•