916979 - Bug.search ignores the "limit" parameter

Status: RESOLVED FIXED

(Bugzilla :: WebService, defect)

Description

[Tiziana Sellitto [:tiziana]]

I'm using json-rpc interface to access Bugzilla API. It seems that from yesterday the "limit" and "creation_time" parameters don't work;

https://bugzilla.mozilla.org/jsonrpc.cgi?method=Bug.search&params=[{"limit":3,"product":"Firefox","component":"Untriaged","status":"UNCONFIRMED","include_fields":["creation_time","id","status","summary","last_change_time" ]}]

and the "creation_time" doesn't return anything:

https://bugzilla.mozilla.org/jsonrpc.cgi?method=Bug.search&params=[{"limit":3,"creation_time":"2011-07-09T17:56:00Z","product":"Firefox","component":"Untriaged","status":"UNCONFIRMED","include_fields":["creation_time","id","status","summary","last_change_time" ]}]


These searches worked fine up to two days ago. 
I've looked at this bug 785565 asking if it could be related.

Comment 1

[:glob ✱]

nothing was changed on production two days ago (the last update was Sep 11 00:15:35 PDT).

as there are two issues reported here, i've split the bug - the creation_time issue is in bug 917157.


the problem with limit is Bugzilla::Bug::map_fields() is converting $params->{limit} to $params->{LIMIT}, however Bugzilla::Search is expecting lowercase {limit} (this also applies to offset).

Comment 2

[David Lawrence [:dkl]]

Attachment: 916979_1.patch

Simple remove LIMIT/OFFSET from FIELD_MAP in Bugzilla::Bug. Also cleaned up my variable naming in Bug.search as it was backwards.

dkl

Comment 3

[:glob ✱]

Comment on attachment 806099 [details] [diff] [review]
916979_1.patch

r=glob

Comment 4

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified Bugzilla/Bug.pm
modified Bugzilla/WebService/Bug.pm
Committed revision 8741.