Closed Bug 917020 Opened 6 years ago Closed 6 years ago

Remove "startup" section from MetroFx options

Categories

(Firefox for Metro Graveyard :: Flyouts, defect)

All
Windows 8.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: TimAbraldes, Assigned: kjozwiak)

References

Details

(Whiteboard: [preview])

Attachments

(2 files)

This was recently discussed on the metro mailing list:
  https://mail.mozilla.org/pipermail/metro/2013-September/000282.html

We will remove the "startup" section from our options panel, and will always act as if "show tabs from last time" is selected.
This is a screenshot highlighting the option that will be removed
I agree we should remove the option, but the default option should be to show start page?

I think that the MS guideline for Metro apps is to resume the session if the app was suspended and killed, but to start fresh if the previous execution state was a fresh close.
Yes, I think Brian is correct.  For those users who do discover "kill it for real" we should start up fresh.  That respects the Windows guidelines and gives the user a simple "get rid of this mess and start fresh" gesture.
Summary: Remove option to show start page on startup → Remove "startup" section from MetroFx options
SGTM. I see the benefit of defaulting to either option and I don't have a strong preference for one over the other
Blocks: 922657
No longer blocks: 922657
Kamil, interested in taking this one?
Sure! Thanks Brian
Assignee: nobody → kamiljoz
Removed the "Startup" labels and menu items from the "Options" panel. Doubled checked metro.js and ensured that when Firefox Metro is killed incorrectly (crashes), that all the tabs are restored.

Went through the following test cases:
- Closed Firefox Metro (killed properly) and ensured that a "fresh slate" was used when re-launching the browser
- Closed Firefox Metro using the Task Manager (incorrect kill) and ensured that all the tabs where restored when the browser was re-launched

Please let me know if I missed something!
Attachment #814696 - Flags: review?(mbrubeck)
Forgot to mention that I left the pref there so it can be used in the future if needed but is not supported by the UI
Comment on attachment 814696 [details] [diff] [review]
removing "Startup" from the "Options" flyout

Review of attachment 814696 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #814696 - Flags: review?(mbrubeck) → review+
Thanks Matt,

Would you be able to push this to the try server if you have some time? Just let me know!
Metro tests passed locally; landing directly to fx-team:
https://hg.mozilla.org/integration/fx-team/rev/10824701bc80
Status: NEW → ASSIGNED
Hardware: x86_64 → All
Whiteboard: [preview-triage] → [preview]
https://hg.mozilla.org/mozilla-central/rev/10824701bc80
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.