917042 - [10.9] File picker often closes when trying to select a file the first time

Status: RESOLVED WORKSFORME

(Core Graveyard :: File Handling, defect)

Description

[Marcia Knous [:marcia]]

Seen while running the latest Aurora build:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:25.0) Gecko/20100101 Firefox/25.0

STR:
1. Go to a bugzilla bug and try to add an attachment using the "Browse" button or the "Add an attachment" button.
2. Observe that the file picker is shown briefly, then closes, and I cannot select the file I want to add.

I get this in the Error Console:

[16:15:36.128] [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://browser/content/aboutDialog.js :: init :: line 14"  data: no] @ chrome://browser/content/aboutDialog.js:32

An additional side effect of this bug is that until I select "downloads" or some other area the browser File Menu only shows "Aurora" and "Edit"

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Mavericks DP8 came out yesterday.  Does this still happen with it?

Comment 2

[Marcia Knous [:marcia]]

(In reply to Steven Michaud from comment #1)
> Mavericks DP8 came out yesterday.  Does this still happen with it?

Yes, can confirm still happening using DP8.

I can try to see if it happens using other browsers as well.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

I can't reproduce this, testing with today's mozilla-aurora nightly on Mavericks DP8 (on a Retina MacBook Pro, if that makes a difference).

Do you see it with a clean profile?

Comment 4

[Marcia Knous [:marcia]]

Will try with a clean profile and report back.

Comment 5

[Marcia Knous [:marcia]]

Happens with a clean profile as well using the latest aurora build.

Comment 6

[Steven Michaud [:smichaud] (Retired)]

Thanks Marcia.

I'm completely stumped :-(

It's particularly puzzling that the error message (from comment #0) concerns the About dialog.

Comment 7

[Marcia Knous [:marcia]]

This is still happening in the Gold Master and I am concerned that this will drive people crazy. Using Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:25.0) Gecko/20100101 Firefox/25.0 (B7), I cannot easily add an attachment to bugzilla.

When I open the file picker I have to *quickly* put focus on a file and then it seems to be ok. If I don't do that, then I have to keep opening the file picker over and over again.

I think it happened when I was trying to upload pictures to Facebook as well, so not just Bugzilla.

Comment 8

[Steven Michaud [:smichaud] (Retired)]

For us to be able to do anything here, we need good STR.

I tried reproducing this in DP8 (using the information then available in this bug) -- I had no luck.  I'll try again in the GM, but I don't really expect my results to be different.

Comment 9

[Marcia Knous [:marcia]]

Here are some STR to reproduce this on Flickr, using Aurora:

1. Navigate to http://www.flickr.com/photos/upload/
2. Select "Choose Photos and Videos"
3. Try to select a file.
4. File picker comes up briefly and then closes.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:26.0) Gecko/20100101 Firefox/26.0. Using Build 13A598.

Comment 10

[Marcia Knous [:marcia]]

Not sure if it matters, but in settings I have "All Controls" set for Keyboard Access.

And in Step #2 I am invoking the dialog with a click from the trackpad and using the trackpad for all navigation (no external mouse).

Comment 11

[Steven Michaud [:smichaud] (Retired)]

I still can't test on the GM (since I haven't yet installed it).  And I don't have a Flickr account, so I can't test the STR from comment #9.

But just now I set Full Keyboard Access to "All controls" (in the Keyboard system prefs panel).  Then I tried the STR from comment #0 over again (with a recent Aurora build on DP8), and still had no problems.

I also used only the trackpad.  I scrolled the page (up, down, left and right) with two fingers.  Then, once I had the mouse over the appropriate button ("Add an attachment" or "Browse"), I clicked down on the trackpad (the equivalent of a left-mouse click).  I never used the Tab key (so the Full Keyboard Access setting shouldn't have made any difference).  I tested on a Retina MBP.

Did you do anything differently, Marcia?

What were the names of the directories you browsed?  Was there anything odd about them?  (I can remember bugs that were triggered by file paths having a space somewhere in them.  These were fixed long ago, but you might have bumped up against something similar.)

Comment 12

[Steven Michaud [:smichaud] (Retired)]

Another thing:

Try your STRs in other browsers, and see if anything weird happens.

Comment 13

[Steven Michaud [:smichaud] (Retired)]

Were the directories you browsed remotely (AFP/NFS/SMB) mounted?  If so you may be seeing a variant of bug 918732.

Does your bug happen in older versions of Firefox?  If not, please try to find a regression range in mozilla-central nightlies?

Comment 14

[Steven Michaud [:smichaud] (Retired)]

> you may be seeing a variant of bug 918732.

Bug 918612.

Comment 15

[Marcia Knous [:marcia]]

Steven: Just tested with the latest Nightly, Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:27.0) Gecko/20100101 Firefox/27.0 and the bug is *not* happening with that build. It does, however, still happen with the latest Aurora build, Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:26.0) Gecko/20100101 Firefox/26.0 when I access the Flickr site and try to upload a picture.

It also does not happen with Chrome. Will do some additional testing with the latest Firefox release as well as the beta.

None of the directories I was trying to access were remote - all were files were resident on my hard drive. My STR were the same as what you noted in Comment 11.

Comment 16

[Steven Michaud [:smichaud] (Retired)]

Thanks for the info, Marcia.

But please please please look for the mozilla-central nightly in which this bug started (presuming that older FF versions don't have it), and the mozilla-central nightly in which it stopped happening.  That should give us valuable information about this bug, even if I'm never able to reproduce it.

Comment 17

[Marcia Knous [:marcia]]

Still working on the range, but going back to Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:27.0) Gecko/20100101 Firefox/27.0 ID:20130930030205 CSet: 8f805d3ef377 this does work using Flickr in the build. I downloaded the 9-15 build but it didn't unpack. Will have more to report today.

Comment 18

[u279076]

Ioana, please have someone on your team see if they can assist Marcia in finding a regression window.

Comment 19

[Ioana (away)]

Manuela is working on this and will update the bug as soon as she has some results.

Comment 20

[Manuela Muntean [Away]]

While investigating this, I couldn't reproduce the part with the file picker closing rapidly. 

I was only able to reproduce the side effect of this bug, which is that the File Menu only shows "Firefox" and "Edit" until I select something to upload (with STR from both comment 0 and comment 9) with Firefox 24, but also with Firefox 4 and Firefox 4.0.1, so it's not a regression.

Comment 21

[Manuela Muntean [Away]]

(In reply to Manuela Muntean [:Manuela] [QA] from comment #20)
> While investigating this, I couldn't reproduce the part with the file picker
> closing rapidly. 
> 
> I was only able to reproduce the side effect of this bug, which is that the
> File Menu only shows "Firefox" and "Edit" until I select something to upload
> (with STR from both comment 0 and comment 9) with Firefox 24, but also with
> Firefox 4 and Firefox 4.0.1, so it's not a regression.

I forgot to mention that I used a Mac OS X 10.8.4 in 32-bit mode machine

Comment 22

[Marcia Knous [:marcia]]

(In reply to Manuela Muntean [:Manuela] [QA] from comment #21)
> (In reply to Manuela Muntean [:Manuela] [QA] from comment #20)
> > While investigating this, I couldn't reproduce the part with the file picker
> > closing rapidly. 
> > 
> > I was only able to reproduce the side effect of this bug, which is that the
> > File Menu only shows "Firefox" and "Edit" until I select something to upload
> > (with STR from both comment 0 and comment 9) with Firefox 24, but also with
> > Firefox 4 and Firefox 4.0.1, so it's not a regression.
> 
> I forgot to mention that I used a Mac OS X 10.8.4 in 32-bit mode machine

Manuela: I think this may only be happening with 10.9, so we need to test with that OS.

Comment 23

[Steven Michaud [:smichaud] (Retired)]

(In reply to comment #20)

> I was only able to reproduce the side effect of this bug, which is
> that the File Menu only shows "Firefox" and "Edit" until I select
> something to upload (with STR from both comment 0 and comment 9)
> with Firefox 24, but also with Firefox 4 and Firefox 4.0.1, so it's
> not a regression.

This isn't a bug; it's a feature :-)

The native filepicker is an app-modal dialog, which means that most
browser features are (or shouldn't be) available while it's open.
Firefox edits the menu to make it less likely these features will be
used.

Comment 24

[Steven Michaud [:smichaud] (Retired)]

> most browser features are (or shouldn't be) available while it's open

most browser features *aren't* (or shouldn't be) available while it's open

Comment 25

[Manuela Muntean [Away]]

(In reply to Marcia Knous [:marcia] from comment #22)
> Manuela: I think this may only be happening with 10.9, so we need to test
> with that OS.

I've investigated also on Mac 10.9, and I can't reproduce the issue. I can only see the "side effect" described in comment 20 (feature as Steven says in comment 23).

Comment 26

[Lukas Blakk [:lsblakk] use ?needinfo]

In that case, this is no longer a tracking issue for FF26 and likely can be resolved WORKSFORME

Comment 27

[Marcia Knous [:marcia]]

Resolving this as WFM - have not seen the issue on 10.9 since initially filed.

Comment 28

[Joshua Mitchell (Inactive)]

Issue is resolved - clearing old keywords - qa-wanted clean-up