917081 - Collections API should allow the image to be cleared for a collection.

Status: RESOLVED FIXED

(Marketplace Graveyard :: API, defect, P3)

Description

[Matt Basta [:basta]]

There is presently no way to remove an image from a collection (to my knowledge). The DELETE command against /rocketfuel/collections/<id|slug>/image/ should delete the image.

Comment 1

[Chuck Harmston [:chuck]]

This isn't reasonably solvable the way images are currently stored. I filed bug 918522 to fix that.

When that is done, we should update CollectionImageViewSet to:
1) Update it to allow DELETE requests (I think; it feels slightly abusive of HTTP, but I'm fine with it).
2) Return a 404 on GET and DELETE requests if an image does not exist.
3) Update the response of CollectionViewSet to return `null` if an image does not exist.

Comment 2

[Matt Basta [:basta]]

(In reply to Chuck Harmston [:chuck] from comment #1)
> 2) Return a 404 on GET and DELETE requests if an image does not exist.

If an image doesn't exist and a DELETE request is made against it, just return a 204. Mission accomplished.

Comment 3

[Chuck Harmston [:chuck]]

Landed: https://github.com/mozilla/zamboni/compare/38f0a4508941...36974fe73c0c
Docs: http://firefox-marketplace-api.readthedocs.org/en/latest/topics/rocketfuel.html#delete--api-v1-rocketfuel-collections-%28int-id|string-slug%29-image-