917144 - list apps included in b2g engineering builds, and prune non-essential apps to reduce size

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Spun out from bug#912617. Found bug#854995 while filing. Guessing this is correct component, but please adjust as needed.


(In reply to Tony Chung [:tchung] from comment #12)
> (In reply to Chris AtLee [:catlee] from comment #8)
> > We are about 4.8 MB over the size limit here, if I'm interpreting this line
> > correctly.
> > 09:08:02     INFO -  error: out/target/product/hamachi/system.img+ too large
> > (197465664 > [194641920 - 2027520])
> > 
> > Tony, Fabrice suggested we may be able to get these working by disabling
> > some of the test apps. Are there any you know of that we could delete?
> 
> good question.  given this is for test automation, i'll defer to stephen's
> team to comment more.   can you list the existing test apps that are in the
> bundle right now?   then we can just go through the list and say
> keep/delete..

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

It's probably easier for build/engineering to list the apps, since you have access to the manifest; my team can answer what we need from the engineering builds, but I know we at least need to keep the Keyboard app.

Also, we're not the only consumer of the engineering builds, so I'm not sure whom else we'd need to ask before removing test apps?

Comment 2

[Zac C (:zac)]

We don't actually use anything aside from the core apps but I know you'll step on the toes of the Persona team if you remove the "UI Tests" app.

Comment 3

[Jason Smith [:jsmith]]

Can someone write a post to dev-gaia about this bug? That will help figure out what we can and can't prune from the build.

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Zac C (:zac) from comment #2)
> We don't actually use anything aside from the core apps but I know you'll
> step on the toes of the Persona team if you remove the "UI Tests" app.

Thank you, this is true; we use the UI Tests app to launch the navigator.mozId and navigator.mozId.get tests.  We'd be glad to move them somewhere else if necessary.

Comment 5

[Aras Balali Moghaddam]

As a volunteer who has been working on a few bugs, I have found uitests app to be extremely useful. It is very handy to reproduce bugs, because it contains minimal use cases for almost every UI feature.

Comment 6

[Roy Collings]

We're using the keyboard and lockscreen apps (actually we only use lockscreen because 'gaiatest.py' uses it, but the keyboard app we use independently).

Comment 7

[krupa raj[:krupa]]

Will it be possible to have marketplace-dev app installed by default on the eng builds?

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Jason Smith [:jsmith] from comment #3)
> Can someone write a post to dev-gaia about this bug? That will help figure
> out what we can and can't prune from the build.

Done yesterday: https://groups.google.com/forum/#!topic/mozilla.dev.gaia/1YQeZmB3P_4

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Removing these, as a start, seems to not hurt anyone's workflow/needs (at least, those that have chimed in, in this bug), and seems to have given us enough space to move forward (for now).

RelEng, can we get these pruned, for now, as a "test"?

rm -rf b2g-distro/gaia/profile/webapps/cubevid*
rm -rf b2g-distro/gaia/profile/webapps/testpermission*
rm -rf b2g-distro/gaia/profile/webapps/image-uploader*
rm -rf b2g-distro/gaia/profile/webapps/crystalskull*
rm -rf b2g-distro/gaia/profile/webapps/test-ime*

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

:vingtetun are you fine with the (few, so far) proposed removals, to help engineering builds flash/run again?  Thanks!

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Stephen Donner [:stephend] from comment #10)
> :vingtetun are you fine with the (few, so far) proposed removals, to help
> engineering builds flash/run again?  Thanks!

Or Jonas?  :-)  RelEng doesn't feel comfortable removing without approval, first.

Comment 12

[[:fabrice] Fabrice Desré]

fwiw, that looks very reasonable to me. I was expecting more pruning :)

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Fabrice also said we could probably remove tests-sensors.

Comment 14

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

These look fine to me.

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please make sure we are patching gaia/build/apps-engineering.list for this bug instead of creating something fancy in releng scripts.

I wouldn't mind if releng opt to use a customized list like apps-engbuild-relengs.list.

Comment 16

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

it's easy to create or modify a set with customization mechanism. e.g., create a file |apps-newset.list| in GAIA_DIR/build/ with:
> apps/system
> apps/keyboard
> apps/homescreen
> apps/settings

and build gaia: |GAIA_APP_CONFIG=build/apps-newset.list make reset-gaia|, you will get a gaia build only with settings app on homescreen.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Yuren Ju [:yurenju] from comment #16)
> it's easy to create or modify a set with customization mechanism. e.g.,
> create a file |apps-newset.list| in GAIA_DIR/build/ with:
> > apps/system
> > apps/keyboard
> > apps/homescreen
> > apps/settings
> 
> and build gaia: |GAIA_APP_CONFIG=build/apps-newset.list make reset-gaia|,
> you will get a gaia build only with settings app on homescreen.

Thanks, Yuren.  We don't self-build (our machines are dedicated to the automation-infrastructure running, itself, and we need Engineering builds with specific scripts, etc.).

I see you've assigned this to yourself; would it be possible to get the apps from comment 9 and comment 13 removed from the list this evening, to help unblock our Unagi and Inari runs?  Thanks!

Comment 18

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

how much size does we need to reduce?

I removed apps mentioned in comment 9 and comment 13 and reduce profile size from 84M to 73M, is it enough?

Comment 19

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: github PR: https://github.com/mozilla-b2g/gaia/pull/12384

remove apps list below to reduce image size for engineering build:
- cubevid
- testpermission
- image-uploader
- crystalskull
- test-ime
- tests-sensors

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 809024 [details] [review]
github PR: https://github.com/mozilla-b2g/gaia/pull/12384

Do remember to send an e-mail to dev-gaia for this. Thanks.

Comment 21

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

email was sent. accroding comment 0, reduce 11M should be enough.

Comment 22

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

added test-ime back because we use it for integration test.

Comment 23

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Yuren Ju [:yurenju] from comment #22)
> added test-ime back because we use it for integration test.

Thanks, Yuren!  Who is able to do this review and unblock us by merging it?

Comment 24

[James Lal [:lightsofapollo]]

https://github.com/mozilla-b2g/gaia/commit/04024bef5846fc510ff3f3759394cc3fcf83d3d1

Comment 25

[James Lal [:lightsofapollo]]

in 1.2: 9fe0880922a133261b2ed38e66df78c83a4fff0e