917176 - [Wifi] Support list imported CA in NSS

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

The API should look like
nsIDOMDOMRequest getCaList();

Should only list CAs imported by wifi manager, so we need to find a identifying method in Bug 917102.

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. IDL Change.

Comment 2

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. DOM API implementation.

Use X509CertDB to get cert list directly.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

I'm going to review this tomorrow (California time).

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8336564 [details] [diff] [review]
0002. DOM API implementation.

Review of attachment 8336564 [details] [diff] [review]:
-----------------------------------------------------------------

r=me pending bsmith's review of the NSS bits.

Comment 5

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. IDL Change. V2

1. Change API function name.
2. Change id of returned object.

Comment 6

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. DOM API implementation. V2

1. Changes corresponding to API function name change.
2. Remove support for user certificate.

Comment 7

[Jason Smith [:jsmith]]

The user story bug this blocks (bug 922930) has a target milestone of future, so this is not a committed feature for 1.3. Non-committed features for 1.3 should not block the release.

Comment 8

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. IDL Change. V3

Rebase.

Comment 9

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. DOM API implementation. V3

Rebase

Comment 10

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. IDL Change. V4

Rebase.

Comment 11

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. DOM API implementation. V4

Rebase.

Comment 12

[Ken Chang[:kenkai]]

After discussing PM, it is not an 1.4+ bug. Put it in backlog.

Comment 13

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. DOM API implementation. V5

Rebase.

Comment 14

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. WebIDL Change.

Update to webIDL.

Comment 15

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. DOM API implementation. V6

Update to webIDL, add new interface.

Comment 16

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. WebIDL Change. V2

Update according to bug 917102 comment 82.

Comment 17

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. DOM API implementation. V7

Update based on WebIDL change.

Comment 18

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8408105 [details] [diff] [review]
0001. WebIDL Change. V2

Review of attachment 8408105 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/MozWifiManager.webidl
@@ +218,5 @@
>                          DOMString certNickname);
>  
>    /**
> +   * Get list of imported WIFI certificates.
> +   * onsuccess: We have successfully get imported certificate list.

Nit: "We have successfully gotten the imported certificate list."

Comment 19

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8408108 [details] [diff] [review]
0002. DOM API implementation. V7

Review of attachment 8408108 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wifi/DOMWifiManager.js
@@ +263,5 @@
>          Services.DOMRequest.fireError(request, msg.data);
>          break;
>  
> +      case "WifiManager:getImportedCerts:Return:OK":
> +        Services.DOMRequest.fireSuccess(request, exposeReadOnly(msg.data));

This won't work anymore. I believe that you're going to have to use some of the APIs on Components.utils to do this properly. See in particular <https://developer.mozilla.org/en-US/docs/Components.utils.createObjectIn>. The idea is that instead of exposing the chrome object directly to content, you expose a content object to content and no security stuff has to be done.

Comment 20

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. DOM API implementation. V8

Address comment 19.

Comment 21

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. WebIDL Change. V2.1

Address comment 18.

Comment 22

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Hi Blake,
   I wonder should I create an interface for returning result of |DOMRequest.onsuccess| like bug 917102, or using |Cu.createObjectIn()| in this patch (if this passed your review)?

Comment 23

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. DOM API implementation. V9

Rebase.

Comment 24

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8413588 [details] [diff] [review]
0002. DOM API implementation. V9

Looks good. Thanks.

Comment 25

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. DOM API implementation. V10. r=mrbkap,briansmith

Rebase.

Comment 26

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try result : https://tbpl.mozilla.org/?tree=Try&rev=b586311119d2
This is second bug to check in.

Comment 27

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/1584de5eeb2f
https://hg.mozilla.org/integration/b2g-inbound/rev/2e55ff7dc0ff

Comment 28

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1584de5eeb2f
https://hg.mozilla.org/mozilla-central/rev/2e55ff7dc0ff