917232 - Replace use of obsolete dialogOverlay.js, in SeaMonkey

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Serge Gautherie (:sgautherie)]

Last use in comm-central repository:
{
/suite/mailnews/addrbook/abListOverlay.xul
    * line 20 -- <script type="application/javascript" src="chrome://global/content/dialogOverlay.js"/>
}

Comment 1

[Philip Chee]

I *think* this can be removed safely. I can't find anything that depends on abListOverlay.xul and also depends on dialogOverlay.js

Comment 2

[Ian Neal]

(In reply to Philip Chee from comment #1)
> I *think* this can be removed safely. I can't find anything that depends on
> abListOverlay.xul and also depends on dialogOverlay.js

Agreed.

Comment 3

[Serge Gautherie (:sgautherie)]

Philip, could you submit a patch?

Comment 4

[Philip Chee]

Attachment: Patch v1.0 Remove dialogOverlay.js

(In reply to Serge Gautherie (:sgautherie) from comment #3)
> Philip, could you submit a patch?
Sure!

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 8523025 [details] [diff] [review]
Patch v1.0 Remove dialogOverlay.js

Review of attachment 8523025 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
(I can't help (more) atm.)

Comment 6

[Karsten Düsterloh]

Comment on attachment 8523025 [details] [diff] [review]
Patch v1.0 Remove dialogOverlay.js

None of the functions defined by dialogOverlay.js is used by any suite file, afaict. Seems pretty safe. (By inspection.)

Comment 7

[Ian Neal]

Comment on attachment 8523025 [details] [diff] [review]
Patch v1.0 Remove dialogOverlay.js

Probably outside the scope of this bug, but should also look at removing the use of dialogOverlay.xul too?

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to Ian Neal from comment #7)
> Probably outside the scope of this bug, but should also look at removing the
> use of dialogOverlay.xul too?

Yes, this is already planned in bug 917024, but related blocking bug(s) has not been filed yet.

Comment 9

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/5985a79b817e

Comment 10

[Serge Gautherie (:sgautherie)]

V.Fixed, per MXR search.

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #8)
> (In reply to Ian Neal from comment #7)
> > should also look at removing the use of dialogOverlay.xul too?
> 
> Yes, this is already planned in bug 917024, but related blocking bug(s) has
> not been filed yet.

Ftr, I filed
Bug 1106536 - Replace use of obsolete dialogOverlay.xul, in SeaMonkey