Closed Bug 917232 Opened 7 years ago Closed 6 years ago

Replace use of obsolete dialogOverlay.js, in SeaMonkey

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

defect
Not set
minor

Tracking

(seamonkey2.33 fixed)

VERIFIED FIXED
seamonkey2.33
Tracking Status
seamonkey2.33 --- fixed

People

(Reporter: sgautherie, Assigned: philip.chee)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

Last use in comm-central repository:
{
/suite/mailnews/addrbook/abListOverlay.xul
    * line 20 -- <script type="application/javascript" src="chrome://global/content/dialogOverlay.js"/>
}
I *think* this can be removed safely. I can't find anything that depends on abListOverlay.xul and also depends on dialogOverlay.js
(In reply to Philip Chee from comment #1)
> I *think* this can be removed safely. I can't find anything that depends on
> abListOverlay.xul and also depends on dialogOverlay.js

Agreed.
Philip, could you submit a patch?
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
(In reply to Serge Gautherie (:sgautherie) from comment #3)
> Philip, could you submit a patch?
Sure!
Attachment #8523025 - Flags: superreview?(mnyromyr)
Attachment #8523025 - Flags: review?(iann_bugzilla)
Attachment #8523025 - Flags: feedback?(bugzillamozillaorg_serge_20140323)
Comment on attachment 8523025 [details] [diff] [review]
Patch v1.0 Remove dialogOverlay.js

Review of attachment 8523025 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
(I can't help (more) atm.)
Attachment #8523025 - Flags: feedback?(bugzillamozillaorg_serge_20140323)
Comment on attachment 8523025 [details] [diff] [review]
Patch v1.0 Remove dialogOverlay.js

None of the functions defined by dialogOverlay.js is used by any suite file, afaict. Seems pretty safe. (By inspection.)
Attachment #8523025 - Flags: superreview?(mnyromyr) → superreview+
Comment on attachment 8523025 [details] [diff] [review]
Patch v1.0 Remove dialogOverlay.js

Probably outside the scope of this bug, but should also look at removing the use of dialogOverlay.xul too?
Attachment #8523025 - Flags: review?(iann_bugzilla) → review+
(In reply to Ian Neal from comment #7)
> Probably outside the scope of this bug, but should also look at removing the
> use of dialogOverlay.xul too?

Yes, this is already planned in bug 917024, but related blocking bug(s) has not been filed yet.
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/5985a79b817e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.33
V.Fixed, per MXR search.
Status: RESOLVED → VERIFIED
(In reply to Serge Gautherie (:sgautherie) from comment #8)
> (In reply to Ian Neal from comment #7)
> > should also look at removing the use of dialogOverlay.xul too?
> 
> Yes, this is already planned in bug 917024, but related blocking bug(s) has
> not been filed yet.

Ftr, I filed
Bug 1106536 - Replace use of obsolete dialogOverlay.xul, in SeaMonkey
You need to log in before you can comment on or make changes to this bug.