917337 - [Clock] Implement Scrolling for Timer Settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Corey Frang [:gnarf]]

The vibration option is specified but the Timer edit window is not scrollable so it is impossible to get to the setting to change it.

All that should need to happen is allow scrolling in the timer window.

Comment 1

[Corey Frang [:gnarf]]

Attachment: patch v1

- Adds overflow-y: auto to #timer-dialog
- Adds a event.preventDefault() on touchstart on the time picker to stop user from scrolling while spinning inputs

Comment 2

[Mike Pennisi [:jugglinmike]]

Comment on attachment 806178 [details] [diff] [review]
patch v1

Review of attachment 806178 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice patch, Corey!

Comment 3

[Mike Pennisi [:jugglinmike]]

master: https://github.com/mozilla-b2g/gaia/commit/909f18894ba8872046afe5bc0a28032a3d331f44

Thanks!

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e892e08252cd

Comment 5

[Mike Pennisi [:jugglinmike]]

Requesting "koi+" because the version 1.2 UI is not fully accessible without this patch.

Comment 6

[Dylan Oliver [:doliver]]

triage: koi+, to get new 1.2 feature to spec

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 909f18894ba8872046afe5bc0a28032a3d331f44 to:
v1.2: f1f2332950802dda42678a44694996bde351d976

Comment 8

[Chris Kreinbring [:CKreinbring]]

Verified on Buri 1.2 mozilla RIL.  User is now able to scroll down the Timer section of the Clock app to see the Vibrate switch.

Build ID: 20130925004005
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/fb764e648a8f
Gaia: b0e4a1333bb7bf0a749a384ba99e4f03f111e39a
Platform Version: 26.0a2