[Clock] Implement Scrolling for Timer Settings

RESOLVED FIXED

Status

Firefox OS
Gaia::Clock
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gnarf, Assigned: gnarf)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The vibration option is specified but the Timer edit window is not scrollable so it is impossible to get to the setting to change it.

All that should need to happen is allow scrolling in the timer window.
(Assignee)

Comment 1

5 years ago
Created attachment 806178 [details] [diff] [review]
patch v1

- Adds overflow-y: auto to #timer-dialog
- Adds a event.preventDefault() on touchstart on the time picker to stop user from scrolling while spinning inputs
Attachment #806178 - Flags: review?(mike)
Comment on attachment 806178 [details] [diff] [review]
patch v1

Review of attachment 806178 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice patch, Corey!
Attachment #806178 - Flags: review?(mike) → review+
master: https://github.com/mozilla-b2g/gaia/commit/909f18894ba8872046afe5bc0a28032a3d331f44

Thanks!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Requesting "koi+" because the version 1.2 UI is not fully accessible without this patch.
blocking-b2g: --- → koi?
triage: koi+, to get new 1.2 feature to spec
blocking-b2g: koi? → koi+
Uplifted 909f18894ba8872046afe5bc0a28032a3d331f44 to:
v1.2: f1f2332950802dda42678a44694996bde351d976
status-b2g-v1.2: --- → fixed
Verified on Buri 1.2 mozilla RIL.  User is now able to scroll down the Timer section of the Clock app to see the Vibrate switch.

Build ID: 20130925004005
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/fb764e648a8f
Gaia: b0e4a1333bb7bf0a749a384ba99e4f03f111e39a
Platform Version: 26.0a2
status-b2g-v1.2: fixed → verified
You need to log in before you can comment on or make changes to this bug.