917348 - Aurora build bustage caused by nsAgg.h accessing _owningThread in non-debug builds

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[(no longer active)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=27972927&tree=Mozilla-Aurora

Comment 1

[(no longer active)]

I'm going to land my patch here without approval.  Sorry!

Comment 2

[(no longer active)]

Attachment: Patch (v1)

I have no idea how this builds elsewhere!

Comment 3

[(no longer active)]

Kyle, your patch in bug 907914 is what broke Aurora today.

Comment 4

[(no longer active)]

Will land on inbound when it gets reopened:

https://hg.mozilla.org/releases/mozilla-aurora/rev/3b28f561358c

Comment 5

[(no longer active)]

Forgot to qrefresh:

https://hg.mozilla.org/releases/mozilla-aurora/rev/4d1892b38d93

Comment 6

[(no longer active)]

Attachment: Part 2

Comment 7

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f18f9c05e3df

Comment 8

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/790b53064b38
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e89d86daa50

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

So what was the mistake in my patch here?  It's not obvious to me from reading ...

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/790b53064b38
https://hg.mozilla.org/mozilla-central/rev/9e89d86daa50

Comment 11

[(no longer active)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #9)
> So what was the mistake in my patch here?  It's not obvious to me from
> reading ...

That patch makes NS_DECL_OWNINGTHREAD do something in both debug *or* nightly builds, which means that if consumers start to depend on _mOwningThread in non-debug configurations, their code will compile fine on mozilla-central and break when uplifted to Aurora.  Last time around, people added at least two of such use cases, which I fixed in this bug.

Comment 12

[Tracy Walker [:tracy]]

I assume that this can be verified by confirming we get Nightly and Aurora builds going forward,

Comment 13

[Bogdan Maris, Desktop Test Engineering]

(In reply to [:tracy] Tracy Walker - QA Mentor from comment #12)
> I assume that this can be verified by confirming we get Nightly and Aurora
> builds going forward,

Nightly and Aurora builds are coming so I guess this is verified. If you need me to verify anything else please let me know.

Comment 14

[(no longer active)]

(In reply to comment #13)
> (In reply to [:tracy] Tracy Walker - QA Mentor from comment #12)
> > I assume that this can be verified by confirming we get Nightly and Aurora
> > builds going forward,
> 
> Nightly and Aurora builds are coming so I guess this is verified. If you need
> me to verify anything else please let me know.

No, there is not much here to verify.  Thanks!