Closed Bug 917348 Opened 6 years ago Closed 6 years ago

Aurora build bustage caused by nsAgg.h accessing _owningThread in non-debug builds

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla27
Tracking Status
firefox26 + verified
firefox27 + verified

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(2 files)

I'm going to land my patch here without approval.  Sorry!
Attached patch Patch (v1)Splinter Review
I have no idea how this builds elsewhere!
Attachment #806037 - Flags: review?(benjamin)
Kyle, your patch in bug 907914 is what broke Aurora today.
Blocks: 907914
Attachment #806037 - Flags: review?(benjamin) → review+
Will land on inbound when it gets reopened:

https://hg.mozilla.org/releases/mozilla-aurora/rev/3b28f561358c
Attached patch Part 2Splinter Review
Attachment #806059 - Flags: review?(benjamin)
Attachment #806059 - Flags: review?(benjamin) → review+
So what was the mistake in my patch here?  It's not obvious to me from reading ...
https://hg.mozilla.org/mozilla-central/rev/790b53064b38
https://hg.mozilla.org/mozilla-central/rev/9e89d86daa50
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #9)
> So what was the mistake in my patch here?  It's not obvious to me from
> reading ...

That patch makes NS_DECL_OWNINGTHREAD do something in both debug *or* nightly builds, which means that if consumers start to depend on _mOwningThread in non-debug configurations, their code will compile fine on mozilla-central and break when uplifted to Aurora.  Last time around, people added at least two of such use cases, which I fixed in this bug.
I assume that this can be verified by confirming we get Nightly and Aurora builds going forward,
Keywords: verifyme
(In reply to [:tracy] Tracy Walker - QA Mentor from comment #12)
> I assume that this can be verified by confirming we get Nightly and Aurora
> builds going forward,

Nightly and Aurora builds are coming so I guess this is verified. If you need me to verify anything else please let me know.
Status: RESOLVED → VERIFIED
Keywords: verifyme
(In reply to comment #13)
> (In reply to [:tracy] Tracy Walker - QA Mentor from comment #12)
> > I assume that this can be verified by confirming we get Nightly and Aurora
> > builds going forward,
> 
> Nightly and Aurora builds are coming so I guess this is verified. If you need
> me to verify anything else please let me know.

No, there is not much here to verify.  Thanks!
You need to log in before you can comment on or make changes to this bug.