Closed Bug 917359 Opened 6 years ago Closed 6 years ago
Remember my choice is exposed for the get
User Media dialog, but shouldn't be
Build: 9/17/2013 Master Device: Inari STR 1. Go to http://mozilla.github.io/webrtc-landing/gum_test.html 2. Select audio Expected The permission prompt should appear with no remember my choice option. Actual The permission prompt appears with a remember my choice option. It appears to be functional as well. This is unsafe to expose to the web in general - remember my choice was not supposed to be exposed right now generally for gUM due to privacy concerns.
I agree this might be a concern, may we get UX confirm on this? There's remember my choice in the design document. BTW shall we distinguish web and app in this case?
(In reply to Alive Kuo [:alive] from comment #1) > I agree this might be a concern, may we get UX confirm on this? There's > remember my choice in the design document. See https://bugzilla.mozilla.org/show_bug.cgi?id=898986#c3. Remember my choice cannot be implemented generally for all permission cases because a user would be required to have an easy path to forgot my choice for privacy reasons. jesup & pauljt could give more information on this if need be. > > BTW shall we distinguish web and app in this case? In bug 898986, we concluded enabling remember my choice for an app was on the table as an option potentially if the settings app perms UI grants control audio/video capture permissions. When I tested this implementation, it looks like the settings apps permissions implementation is not updated to include audio/video capture permissions, which means we can't enable remember my choice safely yet. Given that we're past feature complete, that likely means we're going to have to go with the decision to disable remember my choice across the board then to meeting the privacy requirements we have.
WIP, consider done but need test once I have better wifi. Will send review after test passed
HI Fred, A quick ping to check on an estimate when this issue will be resolved.I see you have a WIP patch in comment #3. All set for review ?
I think it can be done this week.
Comment on attachment 813939 [details] pull request redirect to github r+ with github comment
Attachment #813939 - Flags: review?(alive) → review+
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/d977e335e9bef01dae60713ffac12922fc32c35b thanks!
I was not able to uplift this bug to v1.2. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1.2 git cherry-pick -x -m1 d977e335e9bef01dae60713ffac12922fc32c35b <RESOLVE MERGE CONFLICTS> git commit
Thanks for reminding. This bug depends on bug 915468, bug 922713, which should be uplift to 1.2. Add approval-1.2 request to those bugs
Uplifted d977e335e9bef01dae60713ffac12922fc32c35b to: v1.2: 15b4458cda572ca9a277f52fe7588381d166161f
Verified on a 1.2 11/1 build that there no longer is a remember my choice option on the gUM audio perm prompt.
You need to log in before you can comment on or make changes to this bug.