Closed Bug 917422 Opened 6 years ago Closed 6 years ago

Change - Update "Do not track" strings and add a "Learn more" link

Categories

(Firefox for Metro Graveyard :: Flyouts, defect, P2)

All
Windows 8.1
defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 27

People

(Reporter: ywang, Assigned: mbrubeck)

References

Details

(Whiteboard: feature=change c=tbd u=tbd p=1)

Attachments

(1 file)

We need to adapt the recent changes for DNT on Android and Firefox OS to stay consistent. 

Notes from Alina's privacy review: https://bugzilla.mozilla.org/show_bug.cgi?id=885129#c13

* DNT three-state (pg 6) - We should make this consistent with how DNT is presented on Fennec and Fx OS v1.2. Here is the copy for the three-state setting in the order in which it should be presented (which is the same across Desktop, Fennec and Fx OS):
--
O Tell websites that I do not want to be tracked.
O Tell websites that I do want to be tracked.
O Do not tell websites anything about my tracking preferences.
--
The default above should be set to the last ('Do not tell...'). 
A screenshot of Firefox OS DNT:
https://bug885129.bugzilla.mozilla.org/attachment.cgi?id=805689&t=BUfdYvdXSK

*If there is no room to include copy about 'How does Do Not Track work', you can include a "Learn More" link to https://www.mozilla.org/en-US/dnt/ under the three options.
Whiteboard: [preview-triage] feature=change c=tbd u=tbd p=0
We won't make this change on Aurora for Fx26 (because of string freeze), but we want to land it in Nightly 27 and let it ride the trains.
Hardware: x86 → All
Whiteboard: [preview-triage] feature=change c=tbd u=tbd p=0 → [preview] feature=change c=tbd u=tbd p=0 [shovel-ready]
Whiteboard: [preview] feature=change c=tbd u=tbd p=0 [shovel-ready] → [shovel-ready] feature=change c=tbd u=tbd p=0
Attached patch patchSplinter Review
The "handle-xul-text-link" notification is used by the label.text-link binding:
http://hg.mozilla.org/mozilla-central/file/cc4a3f3f899e/toolkit/content/widgets/text.xml#l282

My implementation in this patch is based on this one from desktop:
http://hg.mozilla.org/mozilla-central/file/cc4a3f3f899e/browser/components/nsBrowserGlue.js#l289
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #812824 - Flags: review?(rsilveira)
Work estimate p=1.
Whiteboard: [shovel-ready] feature=change c=tbd u=tbd p=0 → [shovel-ready] feature=change c=tbd u=tbd p=1
Blocks: metrov1it16
No longer blocks: metrov1backlog
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [shovel-ready] feature=change c=tbd u=tbd p=1 → feature=change c=tbd u=tbd p=1
Comment on attachment 812824 [details] [diff] [review]
patch

Review of attachment 812824 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: browser/metro/base/content/browser-ui.js
@@ +580,5 @@
> +        let handled = aSubject.QueryInterface(Ci.nsISupportsPRBool);
> +        if (!handled.data) {
> +          this.addAndShowTab(aData, Browser.selectedTab);
> +          handled.data = true;
> +        }

I think the options flyout should dismiss once we click the link, like when you click on the privacy policy link in the about flyout.

::: browser/metro/base/content/browser.xul
@@ +691,3 @@
>            </radiogroup>
>          </setting>
> +        <label class="text-link" href="https://www.mozilla.org/dnt">&doNotTrack.learnMoreLink;</label>

Shouldn't the href be localizable? We seem to keep our urls as a pref: https://mxr.mozilla.org/mozilla-central/source/browser/metro/profile/metro.js#401
Attachment #812824 - Flags: review?(rsilveira) → review+
Landed on fx-team with review addressed (see below):
https://hg.mozilla.org/integration/fx-team/rev/30d25df61046

(In reply to Rodrigo Silveira [:rsilveira] from comment #4)
> I think the options flyout should dismiss once we click the link, like when
> you click on the privacy policy link in the about flyout.--

Good idea.  I added code to FlyoutPanelsUI to hide the flyout when we open a new tab.

> Shouldn't the href be localizable? We seem to keep our urls as a pref:
> https://mxr.mozilla.org/mozilla-central/source/browser/metro/profile/metro.js#401

Simple redirects like this don't need to be localizable -- in fact, some of the ones in the prefs are not localizable.  Since this URL is only used by this one link, I think we might as well just put it in the XUL href attribute, like desktop Firefox does:
http://mxr.mozilla.org/mozilla-central/search?string=mozilla.org/dnt
https://hg.mozilla.org/mozilla-central/rev/30d25df61046
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Went through the following "Change" for iteration #16 without issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-22-03-02-02-mozilla-central/

- Ensured that the changes requested in comment #0 have been implemented without any issues
- Ensured that the change requested in comment #4 has been implemented without any issues
- Ensured that "Do not tell websites anything about my tracking preferences." is selected by default when initially launching Firefox Metro
- Used donottrack.us to ensure that all three options are working correctly
- Ensured that "Learn more..." worked correctly without any issues (taking the user to the correct website)
- Ensured that the users selection is saved when closing/opening the browser (went through all three selections)
- Ensured that all of the above test cases worked in filled and full views without any issues
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0
Mozilla/5.0 (Windows NT 6.2; rv:27.0) Gecko/20100101 Firefox/27.0
Build ID: 20131028030205

Tested on latest nightly using the scenarios from comment 7 and got the same results.

Marking as verified.
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.