Closed Bug 917454 Opened 6 years ago Closed 6 years ago

[typed objs] Add objectType function

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: nmatsakis, Assigned: nmatsakis)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

No longer depends on: harmony:typedobjects
Attached patch Bug917454.diff (obsolete) — Splinter Review
Assignee: general → nmatsakis
Attachment #824949 - Flags: review?(till)
Comment on attachment 824949 [details] [diff] [review]
Bug917454.diff

Review of attachment 824949 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! r=me with nits addressed. And then there's the obligatory reminder to add a license header to the test file. :)

::: js/src/builtin/TypedObject.cpp
@@ +41,5 @@
>      JS_ConvertStub
>  };
>  
> +static const JSFunctionSpec TypedObjectMethods[] = {
> +    {"objectType", {nullptr, nullptr}, 1, 0, "TypeOfTypedDatum"},

Please use the JS_SELF_HOSTED_FN macro here.

@@ +1336,5 @@
> +GlobalObject::initTypedObject(JSContext *cx, Handle<GlobalObject*> global)
> +{
> +    RootedObject TypedObject(cx);
> +    TypedObject = NewObjectWithGivenProto(cx, &TypedObjectClass, global->getOrCreateObjectPrototype(cx),
> +                                   global, SingletonObject);

Nit: indentation is off
Attachment #824949 - Flags: review?(till) → review+
Try run: https://tbpl.mozilla.org/?tree=Try&rev=1bf9e812b23e

appears to be clean, though numerous infrastructure failures make it a bit hard to be sure.
Attached patch Bug917454.diffSplinter Review
Carrying over r+ from till
Attachment #824949 - Attachment is obsolete: true
Attachment #8335491 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/dcda572f9956
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Keywords: dev-doc-needed
Whiteboard: [qa-] → [qa-][DocArea=JS]
Keywords: dev-doc-needed
Whiteboard: [qa-][DocArea=JS] → [qa-]
You need to log in before you can comment on or make changes to this bug.