917544 - getUserMedia access on the web on Firefox OS persists permissions in the session, but shouldn't be

Status: VERIFIED FIXED

(Core :: WebRTC, defect)

Description

[Jason Smith [:jsmith]]

Build: 9/17/2013 Master
Device: Inari

STR

1. Go to http://mozilla.github.io/webrtc-landing/gum_test.html
2. Select Audio
3. Grant permissions when the perm prompt appears
4. Reload the page
5. Select Audio

Expected

A permission prompt should appear asking for access to your microphone.

Actual

The website is immediately granted access to your microphone. This means we persisted the permissions in the session we granted previously to grant access to the microphone. This is bad for getUserMedia because that's a violation of privacy given that a site then has the ability to ask upfront, kill capture, and silently enable capture later when the user does not expect it. We need to disable session persistence for getUserMedia permissions.

Comment 1

[Ivan Tsay (:ITsay)]

The permission should not be persistent for the browser session.

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

The permission request on Firefox OS has only two behaviors, remember it permanently or remember it for a session. Providing "not remember" behavior for audio/video capturing permission should do the trick.

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: not-session-for-audio-capture-permission.patch

Not remember audio-capture permission in a session.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 810366 [details] [diff] [review]
not-session-for-audio-capture-permission.patch

Review of attachment 810366 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed.

::: b2g/components/ContentPermissionPrompt.js
@@ +13,5 @@
>  const Cu = Components.utils;
>  const Cc = Components.classes;
>  
>  const PROMPT_FOR_UNKNOWN = ["geolocation", "desktop-notification", "audio-capture"];
> +const PERMISSION_NO_SESSION = ["audio-capture"];

nit: can you align both '=' and check the 80 chars limit?
Also, add comments to explain what this is used for.

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 810366 [details] [diff] [review]
not-session-for-audio-capture-permission.patch

Review of attachment 810366 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed.

::: b2g/components/ContentPermissionPrompt.js
@@ +13,5 @@
>  const Cu = Components.utils;
>  const Cc = Components.classes;
>  
>  const PROMPT_FOR_UNKNOWN = ["geolocation", "desktop-notification", "audio-capture"];
> +const PERMISSION_NO_SESSION = ["audio-capture"];

nit: can you align both '=' and check the 80 chars limit?
Also, add comments to explain what this is used for.

Comment 6

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: not-session-for-audio-capture-permission.patch

Update patch according to review comment, carry r+.

Comment 7

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

https://tbpl.mozilla.org/?tree=Try&rev=853a07250dfb

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b8e4e12a91d9

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b8e4e12a91d9

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f45c9cf22f32

Comment 11

[Jason Smith [:jsmith]]

lgtm - I'm seeing the prompt reappear upon multiple gUM requests in an app/browser & across reloads.