Closed Bug 917545 Opened 6 years ago Closed 3 years ago

Remove use of obsolete globalOverlay.xul, in SeaMonkey

Categories

(MailNews Core :: Composition, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 52.0

People

(Reporter: iann_bugzilla, Assigned: aceman)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 1 obsolete file)

As far as I can see overlaying globalOverlay.xul is only being used to load globalOverlay.js, none of the xul seems to be used.
And, ftr,
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/globalOverlay.js
is not deprecated.

***

IanN, did you mean this bug to be /suite/ specific?
(As SeaMonkey would include /editor/ui/ too, wouldn't it?)
Severity: normal → minor
Flags: needinfo?(iann_bugzilla)
(In reply to Serge Gautherie (:sgautherie) from comment #1)
> And, ftr,
> http://mxr.mozilla.org/mozilla-central/source/toolkit/content/globalOverlay.
> js
> is not deprecated.
> 
> ***
> 
> IanN, did you mean this bug to be /suite/ specific?
> (As SeaMonkey would include /editor/ui/ too, wouldn't it?)

editor/ui/ is shared with TB, so I would say a bug should be raised against MailNews Core for those instances.
Flags: needinfo?(iann_bugzilla)
Attached patch patch for /editor/ui/dialogs (obsolete) — Splinter Review
I made the part for dialogs, that are also used in TB.
Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=32fbe3f550f8c5118848bcf294809ec64934b0d4 but I think the tests do not test the dialogs much. Only the image-insertion-dialog. That test has a failure in the run, but that happens also without the path.
Attachment #8762156 - Flags: review?(iann_bugzilla)
Comment on attachment 8762156 [details] [diff] [review]
patch for /editor/ui/dialogs

As far as I can see, there is nothing that depends on the utilityOverlay.xul or what it loads, so r/a=me
Attachment #8762156 - Flags: review?(iann_bugzilla) → review+
See Also: → 1313288
As far as I see it this was never checked in. globalOverlay.xul is gone now with bug 1313039 and bug 1313288. Acmeman would you like to un-bitrot the patch or I can also do it?
Flags: needinfo?(acelists)
Yeah, it seems references to globalOverlay.xul are gone from all of c-c. So remove the utilityOverlay.xul references.
Assignee: nobody → acelists
Attachment #8762156 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Flags: needinfo?(acelists)
Attachment #8810221 - Flags: review?(jorgk)
Comment on attachment 8810221 [details] [diff] [review]
patch for /editor/ui/dialogs v2

Review of attachment 8810221 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not going to test or build this. Put rs=jorgk.
You know what you're doing, right?
Attachment #8810221 - Flags: review?(jorgk) → review+
I tested the dialogs and looked if functions from utilityOverlay.js are called. I didn't spot any problems. So let's try it.
Component: UI Design → Composition
Keywords: checkin-needed
Product: SeaMonkey → MailNews Core
https://hg.mozilla.org/comm-central/rev/9d31ee8ebb34089fe82ca05e8d0c24a5cacdf1f6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in before you can comment on or make changes to this bug.