917545 - Remove use of obsolete globalOverlay.xul, in SeaMonkey

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Ian Neal]

As far as I can see overlaying globalOverlay.xul is only being used to load globalOverlay.js, none of the xul seems to be used.

Comment 1

[Serge Gautherie (:sgautherie)]

And, ftr,
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/globalOverlay.js
is not deprecated.

***

IanN, did you mean this bug to be /suite/ specific?
(As SeaMonkey would include /editor/ui/ too, wouldn't it?)

Comment 2

[Ian Neal]

(In reply to Serge Gautherie (:sgautherie) from comment #1)
> And, ftr,
> http://mxr.mozilla.org/mozilla-central/source/toolkit/content/globalOverlay.
> js
> is not deprecated.
> 
> ***
> 
> IanN, did you mean this bug to be /suite/ specific?
> (As SeaMonkey would include /editor/ui/ too, wouldn't it?)

editor/ui/ is shared with TB, so I would say a bug should be raised against MailNews Core for those instances.

Comment 3

[:aceman]

Attachment: patch for /editor/ui/dialogs

I made the part for dialogs, that are also used in TB.
Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=32fbe3f550f8c5118848bcf294809ec64934b0d4 but I think the tests do not test the dialogs much. Only the image-insertion-dialog. That test has a failure in the run, but that happens also without the path.

Comment 4

[Ian Neal]

Comment on attachment 8762156 [details] [diff] [review]
patch for /editor/ui/dialogs

As far as I can see, there is nothing that depends on the utilityOverlay.xul or what it loads, so r/a=me

Comment 5

[Frank-Rainer Grahl (:frg)]

As far as I see it this was never checked in. globalOverlay.xul is gone now with bug 1313039 and bug 1313288. Acmeman would you like to un-bitrot the patch or I can also do it?

Comment 6

[:aceman]

Attachment: patch for /editor/ui/dialogs v2

Yeah, it seems references to globalOverlay.xul are gone from all of c-c. So remove the utilityOverlay.xul references.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8810221 [details] [diff] [review]
patch for /editor/ui/dialogs v2

Review of attachment 8810221 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not going to test or build this. Put rs=jorgk.
You know what you're doing, right?

Comment 8

[:aceman]

I tested the dialogs and looked if functions from utilityOverlay.js are called. I didn't spot any problems. So let's try it.

Comment 9

[:aceman]

https://hg.mozilla.org/comm-central/rev/9d31ee8ebb34089fe82ca05e8d0c24a5cacdf1f6