Use INSTALL_TARGETS for mochitests

RESOLVED FIXED in mozilla27

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla27
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
On the longer term, this should use install manifests, but that'd require more effort than i'm willing to put right now (moving MOCHITEST_* variables to moz.build, etc., and dealing with bug 911375)

Hopefully, this will solve the weird issues i'm having on try with bug 907365.
(Assignee)

Comment 1

5 years ago
Created attachment 806368 [details] [diff] [review]
Use INSTALL_TARGETS for mochitests

While there, i removed the relativesrcdir check, since it's now essentially set everywhere.
Attachment #806368 - Flags: review?(gps)

Comment 2

5 years ago
Comment on attachment 806368 [details] [diff] [review]
Use INSTALL_TARGETS for mochitests

Review of attachment 806368 [details] [diff] [review]:
-----------------------------------------------------------------

I thought we created the _A, etc targets because of extra long command names. I believe INSTALL_TARGETS commands everything on the same command invocation. So we might be in for a bad time when this lands.
Attachment #806368 - Flags: review?(gps) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Gregory Szorc [:gps] from comment #2)
> I thought we created the _A, etc targets because of extra long command
> names. I believe INSTALL_TARGETS commands everything on the same command
> invocation. So we might be in for a bad time when this lands.

INSTALL_TARGETS doesn't do everything in one command.
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/54e4a1ad2b22
Whiteboard: With removed duplicates, missed stuff, and new stuff, r+ed on irc.
(Assignee)

Updated

5 years ago
Whiteboard: With removed duplicates, missed stuff, and new stuff, r+ed on irc.

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/54e4a1ad2b22
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
(Assignee)

Updated

5 years ago
Blocks: 920223
(Assignee)

Updated

5 years ago
Depends on: 920891

Comment 6

5 years ago
This broke Nightly builds:

https://tbpl.mozilla.org/php/getParsedLog.php?id=28423679&tree=Mozilla-Central&full=1#error0

Yeah, WTF pymake. Good news is we can work around it by converting offending directories to manifests.

Updated

5 years ago
Blocks: 921198
(Assignee)

Updated

4 years ago
Depends on: 925766
You need to log in before you can comment on or make changes to this bug.