917622 - Use INSTALL_TARGETS for mochitests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

On the longer term, this should use install manifests, but that'd require more effort than i'm willing to put right now (moving MOCHITEST_* variables to moz.build, etc., and dealing with bug 911375)

Hopefully, this will solve the weird issues i'm having on try with bug 907365.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Use INSTALL_TARGETS for mochitests

While there, i removed the relativesrcdir check, since it's now essentially set everywhere.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 806368 [details] [diff] [review]
Use INSTALL_TARGETS for mochitests

Review of attachment 806368 [details] [diff] [review]:
-----------------------------------------------------------------

I thought we created the _A, etc targets because of extra long command names. I believe INSTALL_TARGETS commands everything on the same command invocation. So we might be in for a bad time when this lands.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #2)
> I thought we created the _A, etc targets because of extra long command
> names. I believe INSTALL_TARGETS commands everything on the same command
> invocation. So we might be in for a bad time when this lands.

INSTALL_TARGETS doesn't do everything in one command.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/54e4a1ad2b22

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/54e4a1ad2b22

Comment 6

[Gregory Szorc [:gps]]

This broke Nightly builds:

https://tbpl.mozilla.org/php/getParsedLog.php?id=28423679&tree=Mozilla-Central&full=1#error0

Yeah, WTF pymake. Good news is we can work around it by converting offending directories to manifests.