Closed Bug 917646 Opened 8 years ago Closed 8 years ago

Unbreak reading of old memory report files.

Categories

(Toolkit :: about:memory, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27
Tracking Status
firefox26 --- fixed
firefox27 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file, 1 obsolete file)

Recent changes to memory reporters (bug 911641 and bug 912165) effectively
changed the file format of memory reports.  This was inadvertent, and while the
file format does have a version number, these changes were small enough that we
can work around them without having to bump the version number.
This patch allows non-sentence descriptions on reports that start with certain
paths, which is enough for the file in bug 916021 to be loaded without error.
Attachment #806410 - Flags: review?(khuey)
Comment on attachment 806410 [details] [diff] [review]
Unbreak reading of old memory report files.

Review of attachment 806410 [details] [diff] [review]:
-----------------------------------------------------------------

njn++
Attachment #806410 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/95ee206d55a5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Here's the patch that landed, which had one extra comment over the reviewed
version.
Attachment #806410 - Attachment is obsolete: true
Attachment #807029 - Flags: review+
Comment on attachment 807029 [details] [diff] [review]
Unbreak reading of old memory report files.

[Approval Request Comment]

Bug caused by (feature/regressing bug #): Bug 911641 and bug 912165.

User impact if declined: Some old memory reports files produced by about:memory (e.g. attachment 804309 [details]) will fail to load.

Testing completed (on m-c, etc.): The patch added testing.  It's been on m-c for a day without problem.

Risk to taking this patch (and alternatives if risky): Very low risk;  the patch just loosens one check done by about:memory during file loading.

String or IDL/UUID changes made by this patch: none.
Attachment #807029 - Flags: approval-mozilla-aurora?
Attachment #807029 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Duplicate of this bug: 918380
You need to log in before you can comment on or make changes to this bug.