917646 - Unbreak reading of old memory report files.

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[Nicholas Nethercote [inactive]]

Recent changes to memory reporters (bug 911641 and bug 912165) effectively
changed the file format of memory reports.  This was inadvertent, and while the
file format does have a version number, these changes were small enough that we
can work around them without having to bump the version number.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Unbreak reading of old memory report files.

This patch allows non-sentence descriptions on reports that start with certain
paths, which is enough for the file in bug 916021 to be loaded without error.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 806410 [details] [diff] [review]
Unbreak reading of old memory report files.

Review of attachment 806410 [details] [diff] [review]:
-----------------------------------------------------------------

njn++

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95ee206d55a5

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/95ee206d55a5

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: Unbreak reading of old memory report files.

Here's the patch that landed, which had one extra comment over the reviewed
version.

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 807029 [details] [diff] [review]
Unbreak reading of old memory report files.

[Approval Request Comment]

Bug caused by (feature/regressing bug #): Bug 911641 and bug 912165.

User impact if declined: Some old memory reports files produced by about:memory (e.g. attachment 804309 [details]) will fail to load.

Testing completed (on m-c, etc.): The patch added testing.  It's been on m-c for a day without problem.

Risk to taking this patch (and alternatives if risky): Very low risk;  the patch just loosens one check done by about:memory during file loading.

String or IDL/UUID changes made by this patch: none.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c1bfb0a8c0a5