917703 - Avoid copying to a sub image in CreateSamplingRestrictedDrawable if possible

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: patch

This is a pretty big win for windows xp TART

Comment 1

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8fcdbbc2dac2

Comment 2

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/25ee493a6e17 so I could get at bug 740200 to back it out.

Comment 3

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/44108fb6f7cc

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out again in https://hg.mozilla.org/integration/mozilla-inbound/rev/1f6d48465290

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Make GetSubimage return an opaque surface if possible

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 807646 [details] [diff] [review]
Make GetSubimage return an opaque surface if possible

Review of attachment 807646 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.

Comment 7

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2bd329f6ba0
https://hg.mozilla.org/integration/mozilla-inbound/rev/063627f4d8c2

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a2bd329f6ba0
https://hg.mozilla.org/mozilla-central/rev/063627f4d8c2

Comment 9

[Jeff Muizelaar [:jrmuizel]]

(In reply to Matt Woodrow (:mattwoodrow) (on holiday until 20 Jan) from comment #5)
> Created attachment 807646 [details] [diff] [review]
> Make GetSubimage return an opaque surface if possible

Does this actually ever happen?