917712 - Firefox should not offer to add invalid search plugins

Status: RESOLVED DUPLICATE of bug 351441

(Firefox :: Search, defect)

Description

[Adrian Stanciu]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:26.0) Gecko/20100101 Firefox/26.0 
Build ID:20130917030214

When trying to add youtube.com to search engines Firefox displays an error and the youtube search engine does not appear in the drop down list as a result.

Steps to reproduce:
1. Navigate to http://www.youtube.com/
2. Click the icon from the left within the search toolbar
3. Click Add "Youtube Video Search"

Actual Results
Firefox displays the following -> Download Error: Nightly could not download the search plugin from: http://www.youtube.com/opensearch?locale=en_US
Firefox does not add the "youtube" search engine.

Expected Results
Firefox should add youtube search engine to the drop down list.

I tried the above in a new profile and in safe mode. Also older versions of Firefox seem to have this bug, so a regression window would be great.

Comment 1

[Alice0775 White]

There is a extra line before xml-declaration :(

> 
> <?xml version="1.0" encoding="UTF-8"?>
> <OpenSearchDescription ...

Comment 2

[Loic]

So TE bug?

Comment 3

[Alice0775 White]

However Firefox also has a bug.
** Firefox should not display menuitem of 'Add "...."', if the xml is invalid.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I re-opened bug 924108 for the TE issue.

The newly-summarized issue requires that we load the plugin before offering it, which is complicated. I'm sure there are other bugs discussing this (related to the name sometimes differing between what's offered in the search dropdown and what ends up installed), but I can't seem to find it at the moment.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

found it!