[Keyboard] Candidate panel displays wrong data when clicking candidate-panel-toggle-button and space key at the same time

RESOLVED FIXED in 1.2 C4(Nov8)

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lchang, Assigned: lchang)

Tracking

unspecified
1.2 C4(Nov8)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 806557 [details]
Screenshot

Please refer to attachment.

STR:

1. find a text field to open keyboard app
2. switch to pinyin layout
3. click 'z', it will show some candidates
4. press down candidate-panel-toggle-button
5. press down space key
6. release candidate-panel-toggle-button
7. release space key
(Assignee)

Comment 1

5 years ago
Created attachment 806567 [details]
Pull Request

This patch tried to prevent triggering the "endPress" event when the target button is invisible.
Attachment #806567 - Flags: review?(rlu)
Blocking, functional issue.
blocking-b2g: koi? → koi+

Updated

5 years ago
Target Milestone: --- → 1.2 C4(Nov8)
Comment on attachment 806567 [details]
Pull Request

r=me.

Thanks for the work.
Attachment #806567 - Flags: review?(rlu) → review+
(Assignee)

Comment 4

5 years ago
travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/13031617

merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/c59be1ad4a0bc005ff648eae59c441cb03771fbf

Rudy, Thanks.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
status-b2g-v1.2: --- → affected
Uplifted c59be1ad4a0bc005ff648eae59c441cb03771fbf to:
v1.2: 35568e976bf44c7a73062558cc0f838c1fa97478
status-b2g-v1.2: affected → fixed
You need to log in before you can comment on or make changes to this bug.