917736 - Add NumberPicker input type to PromptInput.java

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Capella [:capella]]

Attachment: Screenshot_2013-09-13-09-54-03.png

In bug 770101 we added a |number| input type (for about:config) and briefly considered adding native NumberPicker input for Android devices that support it (android.os.Build.VERSION.SDK_INT > 10, or versions starting with Honeycomb) to PromptInput.java , but decided to tackle that here in a dedicated bug.

I think the last point of contention is that due to a limitation of the NumberPicker object, we have to provide user input for a +/- toggle to enable entry of the entire range of Integer values.

The widget allows scrolling through the number range 0-MAXINT, as well as tapping the edit box and manually keying values to avoid scrolling to ridiculously large numbers.

wesj: I think the sticking point here is the UI presentation?

Comment 1

[Wesley Johnston (:wesj)]

Yeah. I don't really like the button. I tried playing with the theme for it a bit, removing the background makes it look unclickable. I'm not sure of a great fix.

Comment 2

[Ian Barlow (:ibarlow)]

Should this just be a simple text entry, then? Seems like the number picker isn't the best way to solve this, given the +/- limitations. So maybe it's just something like 

-----------------------------------------------------


Enter a value for newnumber, between -3 and 300 (or whatever the limits are)

[input field]

Cancel | OK

Comment 3

[Mark Capella [:capella]]

Since that's pretty much what's in place now, I guess I'll just give up on the NumberPicker ... sighs ... I liked it though ;-P